hg: kulla/dev/langtools: 8081849: JShelll API: Code style for enum values is to use CONSTANT_CASE

[ShinyaYoshida]

Hi Robert,
SubKind.ImportSubKind is still CamelCase:
http://hg.openjdk.java.net/kulla/dev/langtools/rev/15782ee3fec9#l6.36
http://hg.openjdk.java.net/kulla/dev/langtools/rev/15782ee3fec9#l1.35

Is this just as you intended?

Regards,
shinyafox(Shinya Yoshida)

2015-06-04 14:35 GMT+09:00 <robert.field at oracle.com>:

> Changeset: 15782ee3fec9
> Author:    rfield
> Date:      2015-06-03 22:35 -0700
> URL:       http://hg.openjdk.java.net/kulla/dev/langtools/rev/15782ee3fec9
>
> 8081849: JShelll API: Code style for enum values is to use CONSTANT_CASE
> Also, rename Variety to SubKind, and similiarly for all accessors,
> internal vars and method, and the enum constants.
>
> ! src/jdk.jshell/share/classes/jdk/internal/jshell/impl/Eval.java
> !
> src/jdk.jshell/share/classes/jdk/internal/jshell/impl/JShellStateImpl.java
> ! src/jdk.jshell/share/classes/jdk/internal/jshell/impl/SnippetImpl.java
> ! src/jdk.jshell/share/classes/jdk/internal/jshell/tool/JShellTool.java
> ! src/jdk.jshell/share/classes/jdk/jshell/JShellState.java
> + src/jdk.jshell/share/classes/jdk/jshell/SubKind.java
> - src/jdk.jshell/share/classes/jdk/jshell/Variety.java
> ! test/jdk/jshell/ClassesTest.java
> ! test/jdk/jshell/IgnoreTest.java
> ! test/jdk/jshell/IllegalArgumentExceptionTest.java
> ! test/jdk/jshell/JShellStateClosedExceptionTest.java
> ! test/jdk/jshell/KullaTesting.java
> ! test/jdk/jshell/MethodsTest.java
> ! test/jdk/jshell/ReplaceTest.java
> ! test/jdk/jshell/SimpleRegressionTest.java
> ! test/jdk/jshell/SnippetTest.java
> ! test/jdk/jshell/VariablesTest.java
>
>