Kulla: Please review JShell API

[Joseph D. Darcy]

Hi Robert,

A few quick comments.

The sources files in the API don't seem to have been compiled with the 
doclint as there seem to be missing javadoc on various methods, etc. 
Please run with

      -Xlint:all -Xdoclint:all/protected

and see what sort of warnings are produced. (Some of the exception types 
might also be missing serialVersionUID fields.)

There doesn't seem to be a package-info.java file for the new package.

Some of the types reference particular sections of "The Java Language 
Specification." In the JDK sources, we use the @jls tag for that 
purpose. There are example uses of the tag in the java.lang package.

The use of fields rather than methods in KeyStatusEvent is not advised.

HTH,

-Joe

On 6/25/2015 12:50 PM, Robert Field wrote:
> Please review the API.  The javadocs can be found here:
>
>     http://cr.openjdk.java.net/~rfield/doc
>
> Sources (as always) are here:
>
>     http://hg.openjdk.java.net/kulla/dev
>
> All comments welcome.
>
> Thanks,
> Robert
>