hg: kulla/dev/langtools: Improving completion inside method header - reported by Andrei

[Jan Lahoda]

Hi Shinya,

Sorry for delayed answer. Looks good - please push.

Thanks,
    Jan

On 12.5.2015 08:35, ShinyaYoshida wrote:
> Hi Jan,
> I think we need more improvement for the completion in the throws clause.
>
> 1. Completion in the throws clause with the fully qualified name
> -> void f() throws java.lang.Num|
> should be NumberFormatException.
>
> 2. Completion for the class which is not subtype of Throwable
> I think the suggestion for the class which is subtype of Throwable
> should have CompletionType.SMART and
> REPL should suggest the type which is not subtype Throwable with
> CompletionType.NORMAL.
>
> Consider the following case:
> -> class HogeHoge { static class HogeHogeException extends Exception {}}
>
> -> void f() throws Hoge[TAB]
> should be HogeHoge with CompletionType.NORMAL.
> And
> -> void f() throws HogeHoge.|
> should be HogeHogeException with CompletionType.SMART.
>
> What do you think?
>
> Here is the patch:
> http://cr.openjdk.java.net/~shinyafox/kulla/201505121/webrev.01/
>
> Regards,
> shinyafox(Shinya Yoshida)
>
> 2015-05-06 16:17 GMT+09:00 <jan.lahoda at oracle.com
> <mailto:jan.lahoda at oracle.com>>:
>
>     Changeset: 837a3bc278fa
>     Author:    jlahoda
>     Date:      2015-05-06 09:17 +0200
>     URL: http://hg.openjdk.java.net/kulla/dev/langtools/rev/837a3bc278fa
>
>     Improving completion inside method header - reported by Andrei
>
>     !
>     src/jdk.jshell/share/classes/jdk/internal/jshell/impl/SourceCodeAnalysisImpl.java
>     ! test/jdk/jshell/CompletionTest.java
>
>