hg: kulla/dev/langtools: 8080349: JShell API: Key for Replaced snippet should == Key for original

robert.field at oracle.com robert.field at oracle.com
Sat May 16 17:35:36 UTC 2015


Changeset: c7b4b5ac1245
Author:    rfield
Date:      2015-05-16 10:35 -0700
URL:       http://hg.openjdk.java.net/kulla/dev/langtools/rev/c7b4b5ac1245

8080349: JShell API: Key for Replaced snippet should == Key for original
Key must be immutable.  Create true KeyImpl and disentangle the logic from SnippetImpl.
Change test assumptions accordingly.
Tighten and clearly defined the Key criteria for imports.  Change the tests accordingly.
Revamp the mapping of keys, snippets, and ids.

! src/jdk.jshell/share/classes/jdk/internal/jshell/impl/JShellImpl.java
! src/jdk.jshell/share/classes/jdk/internal/jshell/impl/JShellStateImpl.java
+ src/jdk.jshell/share/classes/jdk/internal/jshell/impl/KeyImpl.java
+ src/jdk.jshell/share/classes/jdk/internal/jshell/impl/KeyMap.java
! src/jdk.jshell/share/classes/jdk/internal/jshell/impl/SnippetImpl.java
! src/jdk.jshell/share/classes/jdk/internal/jshell/impl/SnippetMaps.java
! src/jdk.jshell/share/classes/jdk/jshell/Key.java
! test/jdk/jshell/ImportTest.java
! test/jdk/jshell/KullaTesting.java
! test/jdk/jshell/SnippetTest.java



More information about the kulla-dev mailing list