RFR 8081266: Tab completion shows static methods on instance variables

[ShinyaYoshida]

Hi all,

I want to ask about documentation for static methods.
Should we not show documentation of static methods on instance variable or
something?

Regards,
shinyafox(Shinya Yoshida)


2015-05-28 8:03 GMT+09:00 ShinyaYoshida <bitterfoxc at gmail.com>:

> Hi Jan,
> Thank you for your review.
>
> Ok, I'll add the test and push.
>
> Regards,
> shinyafox(Shinya Yoshida)
>
> 2015-05-28 2:15 GMT+09:00 Jan Lahoda <jan.lahoda at oracle.com>:
>
>> Hi Shinya,
>>
>> Overall, looks good to me. My only concern is if the tests are not a
>> little bit weaker now than before. Maybe we could add:
>> assertCompletion("new Clazz() {}.fiel|", "field");
>> above:
>> assertEval1("class Clazz implements Interface {}");
>> in testFields? Just so that we ensure the inherited fields work.
>>
>> Not need for another round of review, please push.
>>
>> Thanks,
>>    Jan
>>
>>
>> On 27.5.2015 15:00, ShinyaYoshida wrote:
>>
>>> Hi Andrei,
>>> Thank you for your review!
>>>
>>> Certainly, that's too long. I've updated my patch to reduce the length:
>>> http://cr.openjdk.java.net/~shinyafox/kulla/8081266/webrev.01/
>>>
>>> Regards,
>>> shinyafox(Shinya Yoshida)
>>>
>>> 2015-05-27 17:56 GMT+09:00 andrei.eremeev <andrei.eremeev at oracle.com>:
>>>
>>>  Hi,
>>>>
>>>> I am Ok with the SQE part of the review.
>>>>
>>>> As for the fix, length of lines should not exceed 80/120 characters per
>>>> line.
>>>> So, length of the line should reduced.
>>>>
>>>> +    private final Predicate<Element> STATIC_ONLY =
>>>> IS_STATIC.or(IS_PACKAGE). ...
>>>>
>>>> Let's wait Jan/Robert response about logic of the fix.
>>>>
>>>> Andrei
>>>>
>>>>
>>>> On 05/27/2015 09:53 AM, ShinyaYoshida wrote:
>>>>
>>>>  Hi,
>>>>> Could you review my patch?
>>>>>
>>>>> I also hid static fields on that context.
>>>>>
>>>>> bugs:
>>>>> https://bugs.openjdk.java.net/browse/JDK-8081266
>>>>>
>>>>> webrev:
>>>>> http://cr.openjdk.java.net/~shinyafox/kulla/8081266/webrev.00/
>>>>>
>>>>> Regards,
>>>>> shinyafox(Shinya Yoshida)
>>>>>
>>>>>
>>>>
>>>>
>