Fix for 8080771
Robert Field
robert.field at oracle.com
Thu May 28 15:05:17 UTC 2015
Resending....
On May 26, 2015 11:49:07 AM Robert Field <robert.field at oracle.com> wrote:
> On 05/26/15 04:08, Andrei Eremeev wrote:
>
> Hi all, Could anybody review the fix? Fix:
> http://cr.openjdk.java.net/~aeremeev/8080771.00/Bug:
> https://bugs.openjdk.java.net/browse/JDK-8080771 Andrei Eremeev
> Sure.
>
> parseSetEditorCmd --
> * My approach would have been to use regular expressions rather than
> hand rolling.
> * There are many other white-space characters besides space.
> * Multiple initial spaces are handled, but if there are multiple
> non-initial spaces occur empty arguments are added.
> * If the break is is removed from the space case then the ++index can
> be too.
> * What about slash escape? Escaped quotes? Do we want to support that?
>
> cmdSetEditor --
> * I'd move the Unexpected EOL message to the cause site in
> parseSetEditorCmd.
>
>
More information about the kulla-dev
mailing list