RFR 8141366: JShell API / tool: Couldn't determine import info exactly with some spaces in the qualifier
ShinyaYoshida
bitterfoxc at gmail.com
Wed Nov 4 11:02:15 UTC 2015
Hi,
When I create the patch, I think that we have to treat some other ignored
elements such as comment-out.
But actually comment-out is already replaced with whitespaces
in compileSource.
So removing whitespaces is most simple and enough to fix this problem.
I've updated my patch, changing the fix and adding somo more test.
webrev: http://cr.openjdk.java.net/~shinyafox/kulla/8141366/webrev.01/
Regards,
shinyafox(Shinya Yoshida)
2015-11-04 16:38 GMT+09:00 Robert Field <robert.field at oracle.com>:
> Thanks for catching this problem.
>
> Could it be fixed, with much less code, by simply removing whitespace?
>
> Thanks,
> Robert
>
>
>
>
> On November 3, 2015 5:03:33 PM ShinyaYoshida <bitterfoxc at gmail.com> wrote:
>
> Hi Robert,
>> Could you review this and commit to jdk9?
>>
>> webrev: http://cr.openjdk.java.net/~shinyafox/kulla/8141366/webrev.00/
>> bugs: https://bugs.openjdk.java.net/browse/JDK-8141366
>>
>> Regards,
>> shinyafox(Shinya Yoshida)
>>
>
>
>
More information about the kulla-dev
mailing list