RFR 8142447: Command change: re-run n-th command should be re-run by id

Robert Field robert.field at oracle.com
Wed Nov 11 08:25:55 UTC 2015


I think that makes a lot of sense to consistently do numeric references as being ids.

Sorry I’m not as responsive as usual. Traveling in Europe, just came from JavaDay Kiev.  Speaking today at Devoxx Antwerp.

-Robert

> On Nov 11, 2015, at 4:31 AM, ShinyaYoshida <bitterfoxc at gmail.com> wrote:
> 
> Hi Robert,
> I propose changing /<n> to /<id>.
> 
> There is no one-to-one correspondence between n-th snippet and snippet id because we have the name space for main, startup and error.
> (Note: When the re-run command is implemented, we have just only one name space for any snippet)
> 
> It makes re-run difficult.
> When we re-run main snippet, we have to add the number of startup snippets and the number of erroneous snippets which appear prior to the snippet what we want to re-run.
> It is very confusing for users.
> 
> You can see the example at bugs: https://bugs.openjdk.java.net/browse/JDK-8142447 <https://bugs.openjdk.java.net/browse/JDK-8142447>
> 
> Here is the patch.
> Webrev: http://cr.openjdk.java.net/~shinyafox/kulla/8142447/webrev.00/ <http://cr.openjdk.java.net/~shinyafox/kulla/8142447/webrev.00/>
> 
> Could you consider and review this?
> 
> Regards,
> shinyafox(Shinya Yoshida)



More information about the kulla-dev mailing list