RFR (xxs): jdk.jshell.TaskFactory code for java.specification.version = 1.9 should be adjusted for Verona

[Iris Clark]

Hi, Jan.

Thanks for the review.

Regards,
iris

-----Original Message-----
From: Jan Lahoda 
Sent: Thursday, November 19, 2015 12:13 PM
To: Iris Clark; Robert Field; Kumar Srinivasan
Cc: kulla-dev at openjdk.java.net; verona-dev at openjdk.java.net
Subject: Re: RFR (xxs): jdk.jshell.TaskFactory code for java.specification.version = 1.9 should be adjusted for Verona

Looks OK to me.

Jan

On 18.11.2015 23:53, Iris Clark wrote:
> Hi, Robert and Kumar.
>
> Please review this two character diff to address the following bug:
>
>      8141104: jdk.jshell.TaskFactory code for java.specification.version = 1.9
>          should be adjusted for Verona
>      https://bugs.openjdk.java.net/browse/JDK-8141104
>
> JEP 223 New Version-String Specification [0] (aka Verona) changes the 
> return Value for various system properties including 
> java.specification.version. The code in jdk.jshell.TaskFactory should be altered to detect the new version ("9"
> instead of "1.9") as follows:
>
> $ hg diff
> diff -r ac125016e012 
> src/jdk.jshell/share/classes/jdk/jshell/TaskFactory.java
> --- a/src/jdk.jshell/share/classes/jdk/jshell/TaskFactory.java  Mon 
> Nov 16 17:10:23 2015 -0800
> +++ b/src/jdk.jshell/share/classes/jdk/jshell/TaskFactory.java  Wed 
> +++ Nov 18 12:11:08 2015 -0800
> @@ -80,7 +80,7 @@
>           if (compiler == null) {
>               throw new UnsupportedOperationException("Compiler not available, must be run with full JDK 9.");
>           }
> -        if (!System.getProperty("java.specification.version").equals("1.9"))  {
> +        if 
> + (!System.getProperty("java.specification.version").equals("9"))  {
>               throw new UnsupportedOperationException("Wrong compiler, must be run with full JDK 9.");
>           }
>           this.fileManager = new MemoryFileManager(
>
> This bug was detected by jdk/jshell/AnalysisTest.java which fails on 
> all platforms.  I have confirmed that it passes when this changeset is applied.
>
> After review, the changeset will be pushed to verona/stage [1].  The 
> changeset will go to jdk9/jdk9 when Verona is pushed to that release.
>
> Thanks,
> Iris
>
> [0] http://openjdk.java.net/jeps/223
> [1] http://hg.openjdk.java.net/verona/stage
>