RFR 8142447: Command change: re-run n-th command should be re-run by id

[ShinyaYoshida]

Thank you for your review!

New one is here:
http://cr.openjdk.java.net/~shinyafox/kulla/8142447/webrev.01/

2015-11-26 9:33 GMT+09:00 Robert Field <robert.field at oracle.com>:

> The code looks good to me.
> Just a couple small review comments:
>
>     The method names cmd*() are reserved for the correspondingly named
> commands called via command registration. Similar, but I'd change the name
> of cmdUseHistoryEntryById(String id).
>
I've changed the name.
So should we also change the name of cmdUseHistoryEntry like this?


>
>     There are no associated tests.
>
Certainly. I've add the test.


>
> Then some questions for general discussion that this raises (they do not
> have to be resolved for this fix to proceed) --
>
>     Does it still make sense to have the /-n form which may be useful at
> times but is a different addressing mechanism?
>

One option is that we make the command "/re <id>|-<n>|!" which covers /<id>
and /-<n>, /!.


>     I don't think it is critical to be able to rerun commands (as opposed
> to snippets), but it would be nice.  One approach would be to give them
> synthetic ids: c1, c2, ... .  Thoughts?
>
I like this feature ;)

Regards,
shinyafox(Shinya Yoshida)


> -Robert
>
>
>
> On 11/10/15 19:31, ShinyaYoshida wrote:
>
> Hi Robert,
> I propose changing /<n> to /<id>.
>
> There is no one-to-one correspondence between n-th snippet and snippet id
> because we have the name space for main, startup and error.
> (Note: When the re-run command is implemented, we have just only one name
> space for any snippet)
>
> It makes re-run difficult.
> When we re-run main snippet, we have to add the number of startup snippets
> and the number of erroneous snippets which appear prior to the snippet what
> we want to re-run.
> It is very confusing for users.
>
> You can see the example at bugs:
> https://bugs.openjdk.java.net/browse/JDK-8142447
>
> Here is the patch.
> Webrev: http://cr.openjdk.java.net/~shinyafox/kulla/8142447/webrev.00/
>
> Could you consider and review this?
>
> Regards,
> shinyafox(Shinya Yoshida)
>
>
>