JShell: source in langtools vs JDK?

Joseph D. Darcy joe.darcy at oracle.com
Wed Sep 16 23:28:38 UTC 2015


On 9/16/2015 3:31 PM, Jonathan Gibbons wrote:
>
>
> On 09/16/2015 03:06 PM, Robert Field wrote:
>> As part of the JShell code review, Maurizio made the case that JShell 
>> should be in the JDK repo rather than langtools repo (where it is in 
>> the Kulla workspace).  We would like additional feedback on this 
>> before proceeding --
>>
>>> On Sep 11, 2015, at 8:25 AM, Maurizio Cimadamore 
>>> <maurizio.cimadamore at oracle.com> wrote:
>>>
>>> One general high-level comment, which I also pointed out elsewhere, 
>>> is that I'm not sure jshell really belongs in langtools; while it's 
>>> semantically (obviously) related to langtools - it is a rather 
>>> different beasts w.r.t. all other tools in langtools-land; the fact 
>>> that it depends on the JDK (for jline, and for JDI in general) makes 
>>> it very hard to run on top of a random JDK and then bootstrapping 
>>> classes - which is a technique widely used to be able to run 
>>> langtools tools w/o having to do a full build cycle. More 
>>> specifically, talking about IDE integration, I don't see how 
>>> IntelliJ/Netbeans langtools projects (and the langtools internal 
>>> developer ant build) could be updated to be able to run/debug jshell 
>>> w/o a full build.
>>
>>
>
> In the Big Picture view of the universe, folk would like to 
> restructure the repos in an OPenJDK forest, at which point the 
> distinction between the langtools and jdk repos will likely disappear, 
> or at least become very (very) blurred.  While that change is not 
> imminent, IMO opinion, it significantly reduces the impact of the 
> reasons why JShell should not be in langtools.

As an aside, I am one of those folk who favor such a restructuring ;-)

As a strawman proposal, I think the root, jdk, langtools, and hotspot 
repos are one logical unit that should be combined together into a 
single repo. However, I don't expect this to change any time before JDK 10.

Cheers,

-Joe


More information about the kulla-dev mailing list