RFR 8152925: JShell: enable corralling of any type declaration, including enum
Robert Field
robert.field at oracle.com
Fri Apr 1 16:07:38 UTC 2016
On 04/01/16 04:08, Jan Lahoda wrote:
> In Eval.java, in processClass and processMethod, why split the
> variable declarations and initializations, and put the initializations
> into a block? Seems that the variables could have initializers as before?
It was an attempt to structurally prevent reuse of the the mutated tree,
but it is probably overkill, I've flatened it back out.
>
> Otherwise, seems OK (and better!) to me.
Yes, cleaner.
Thanks for the review!
-Robert
>
> Jan
>
> On 29.3.2016 08:23, Robert Field wrote:
>> Bug:
>> https://bugs.openjdk.java.net/browse/JDK-8152925
>>
>> Webrev:
>> http://cr.openjdk.java.net/~rfield/8152925.webrev/
>>
>> Thanks,
>> Robert
>>
More information about the kulla-dev
mailing list