RFR 8153716: JShell tool: should warn when failed to launch editor

[KUBOTA Yuji]

Ah, I had a misunderstand about this jvm option.
Thank you for catching and adding test!

I will make patch of other reported feedback.

Thanks,
Yuji

2016-04-10 3:50 GMT+09:00 Robert Field <robert.field at oracle.com>:
> Fix pushed!
>
> The link you provided lead me to the property.  Which meant a test could be
> written with:
>
>     System.setProperty("java.awt.headless", "true")
>
> -Robert
>
>
> On 04/08/16 01:49, KUBOTA Yuji wrote:
>>
>> Sorry, I do not have an idea to reproduce within Java. I checked some
>> tests which may be related with headless, e.g.,
>> jdk/test/java/awt/Toolkit/Headless/HeadlessToolkit.java. But they
>> require to run in headless mode.
>>
>> Thanks,
>> Yuji
>>
>> 2016-04-08 15:47 GMT+09:00 Robert Field <robert.field at oracle.com>:
>>>
>>> It will need a regression test, if possible.  Is there a way to reproduce
>>> this exception within Java?  Make Java think it is headless?
>>>
>>> Thanks,
>>> Robert
>>>
>>>
>>>
>>>
>>>
>>>
>>> On April 7, 2016 11:36:10 PM Robert Field <robert.field at oracle.com>
>>> wrote:
>>>
>>>> Nice. I'll push in the morning.
>>>>
>>>> -Robert
>>>>
>>>>
>>>> On April 7, 2016 11:25:22 PM KUBOTA Yuji <kubota.yuji at gmail.com> wrote:
>>>>
>>>>> Hi Robert,
>>>>>
>>>>> Thanks for comment. Certainly for users, "something happen" is very
>>>>> unkind.
>>>>>
>>>>> I updated my patch to show the exception message:
>>>>>   http://cr.openjdk.java.net/~ykubota/8153716/webrev.01/
>>>>>
>>>>> Thanks,
>>>>> Yuji
>>>>>
>>>>> 2016-04-08 1:14 GMT+09:00 Robert Field <robert.field at oracle.com>:
>>>>>>
>>>>>> Yuji,
>>>>>>
>>>>>> Looks good, I wonder if showing the exception (or the exception
>>>>>> message)
>>>>>> would be useful, rather than just a mystery of it not launching?   For
>>>>>> example, seeing that it is headless.
>>>>>>
>>>>>> -Robert
>>>>>>
>>>>>>
>>>>>> On 04/07/16 02:04, KUBOTA Yuji wrote:
>>>>>>>
>>>>>>>
>>>>>>> I filed the proposal which reported at below:
>>>>>>>
>>>>>>> http://mail.openjdk.java.net/pipermail/kulla-dev/2016-April/001305.html
>>>>>>>
>>>>>>> Bug:
>>>>>>>     https://bugs.openjdk.java.net/browse/JDK-8153716
>>>>>>>
>>>>>>> Webrev:
>>>>>>>     http://cr.openjdk.java.net/~ykubota/8153716/webrev.00/
>>>>>>>
>>>>>>> I'm an author, not committer, so I need sponsor.
>>>>>>> Please review it.
>>>>>>>
>>>>>>> Thanks,
>>>>>>> Yuji
>>>>>>
>>>>>>
>>>>>>
>>>
>