RFR 8143955: JShell tool (UX): Output structure

Jan Lahoda jan.lahoda at oracle.com
Tue Apr 12 17:46:58 UTC 2016


Overall, seems OK. One question: why is e.g. ToolSimpleTest using NL = 
System.getProperty("line.separator"); instead of '\n'? AFAIK, using '\n' 
as the newline should be OK on all platforms, as the output is 
normalized from System.getProperty("line.separator") to '\n' (see 
ReplToolTesting.normalizeLineEndings).

Jan

On 10.4.2016 07:13, Robert Field wrote:
> This is the new feedback definitions.
> Besides the configuration commands (embedded in the properties file),
> and a few output fix-ups, this is mostly lots of test changes,
>
> Bug:
>      8143955: JShell tool (UX): Output structure
>      8143956: JShell tool (UX): default prompts
>
> Webrev:
>      http://cr.openjdk.java.net/~rfield/8143955.webrev/
>
> Thanks,
> Robert
>


More information about the kulla-dev mailing list