RFR 8151754/8150382: jshell tool command options: -R<flag> -feedback <mode> -q -qq -v and supporting API

Jan Lahoda jan.lahoda at oracle.com
Wed Apr 20 13:30:30 UTC 2016


Since the JShell.java change is an API, I'd suggest to use:

public Builder remoteVMOptions(String... options)

Where each element of the array would be an actual option, even if it 
included a space. I am not sure if an option with a space would 
currently in practice work when doing the JDI launch, but I think the 
API should be open to options like that.

Otherwise, looks OK to me.

Jan

On 20.4.2016 06:17, Robert Field wrote:
> Bugs:
>      8150382: JShell API: Allow setting remote JVM arguments
>      https://bugs.openjdk.java.net/browse/JDK-8150382
>
>      8151754: jshell tool: add command line options for setting feedback
> mode
>      https://bugs.openjdk.java.net/browse/JDK-8151754
>
> webrev:
>       http://cr.openjdk.java.net/~rfield/8150382.webrev/
>
> Thanks,
> Robert
>


More information about the kulla-dev mailing list