RFR 8154485: JShell: infrastructure for multi-Snippet class wrappers

Jan Lahoda jan.lahoda at oracle.com
Mon Apr 25 14:27:30 UTC 2016


Hi,

In Eval.compileAndLoad, there's code that is commented out (I assume it 
is the next phase for this). Might be better to not include the 
commented out code, and add it uncommented in the next phase.

Nit: there appear to be newly added unused imports in JShell.java, 
Wrap.java, OuterImportSnippetWrap.java.

Otherwise, I'm OK with this,

Jan

On 18.4.2016 23:37, Robert Field wrote:
> Bugs:
>      https://bugs.openjdk.java.net/browse/JDK-8154485
>      https://bugs.openjdk.java.net/browse/JDK-8154377
>
> Webrev:
>      http://cr.openjdk.java.net/~rfield/8154485.webrev/
>
> Thanks,
> Robert
>


More information about the kulla-dev mailing list