RFR (s) 8158906: JShell: crashes with extremely long result value

ShinyaYoshida bitterfoxc at gmail.com
Fri Aug 19 23:21:54 UTC 2016


LGTM!!

Thank you,
shinyafox(Shinya Yoshida)

2016/08/20 午前5:04 "Robert Field" <robert.field at oracle.com>:

> Thanks Shinya and Jan for the comments/reviews!
>
> I've updated
>   * Changed the max to 2 ^ 16 / 3 -1
>   * Put that in a constant
>   * Added Shinya's test
>   * Switched to assertFalse
>   * Changed both tests to test edge conditions
>
> New webrev:
>    http://cr.openjdk.java.net/~rfield/8158906v1.webrev/
>
> -Robert
>
>
> On 08/18/16 18:15, Robert Field wrote:
>
>> Please review...
>>
>> Bug:
>>     https://bugs.openjdk.java.net/browse/JDK-8158906
>>
>> Webrev:
>>     http://cr.openjdk.java.net/~rfield/8158906v0.webrev/
>>
>> Thanks,
>> Robert
>>
>>
>


More information about the kulla-dev mailing list