RFR JDK-8156911: JShell: file manager should be closed

Robert Field robert.field at oracle.com
Mon Aug 22 15:52:45 UTC 2016


Looks good.

-Robert

On 08/22/16 02:15, Jan Lahoda wrote:
> Hi,
>
> Bug:
> https://bugs.openjdk.java.net/browse/JDK-8156911
>
> The constructor of SourceCodeAnalysisImpl.SourceCache creates a 
> JavaFileManager. It will close it eventually (see SourceCache.closed), 
> but if setLocationFromPaths fails with an exception, the file manager 
> won't be closed. This patch fixes that:
> http://cr.openjdk.java.net/~jlahoda/8156911/webrev.00/
>
> Does this look OK?
>
> Thanks,
>     Jan



More information about the kulla-dev mailing list