RFR 8172102: jshell tool: remove print method forwarding to System.out from default startup

Robert Field robert.field at oracle.com
Fri Dec 30 18:35:55 UTC 2016


My bad.  I didn't check in the new files.  The standard startups are 
checked-in files.  Here is the new webrev:

     http://cr.openjdk.java.net/~rfield/8172102v1.webrev/

-Robert



On 12/30/16 10:17, Brian Goetz wrote:
> I think the use of path syntax here is a bit of an abuse.  Typically, 
> a path A:B represents a search path; first look in A, and then, if not 
> found, look in B.  But what you want to indicate is that we should 
> process A *and* B at startup; this isn't a path.
>
> Unfortunately, there's not a universally accepted "and" character, 
> where you could say "A,B" or "A+B" that people would immediately 
> grok.  So better to use repeated flags:
>
>     jshell --startup A --startup B
>
> which is a bit verbose, but I think is more standard.
>
> I'd also prefer to see the standard startup be an actual, checked-in 
> file called something like resources/DEFAULT.jsh, which is placed in 
> the output directory alongside classfiles through the usual build 
> mechanics, rather than living in code.  I don't see that in the webrev?
>
>
>
> On 12/30/2016 1:08 PM, Robert Field wrote:
>> Please review...
>>
>> Bug:
>>
>>     https://bugs.openjdk.java.net/browse/JDK-8172102
>>
>> Webrev:
>>
>>     http://cr.openjdk.java.net/~rfield/8172102v0.webrev/
>>
>> Thanks,
>> Robert
>>
>



More information about the kulla-dev mailing list