RFR 8146138 et. al.: jshell tool: add /help command plus misc fixes

[Jan Lahoda]

Hi Robert,

Overall, seems OK to me.

Comments:
-in the external editor handling, do we need to care about editor 
commands that have a space in the path? (I.e. is there a need for the 
user to quote the external editor path?)
-I am not quite sure which part of the patch relates to JDK-8147898 
(/reload quiet)?
-in JShellTool.cmdHelp(), when the full help is constructed for 
commands, it always ends with "\n\n", which then produces several empty 
lines at the end of the help when printed. Would it make sense to strip 
some of the trailing newlines so that there would be only a single empty 
line between the help and the prompt?
-just a note about future - we might provide a completion for /help as well.

Jan

On 28.1.2016 22:41, Robert Field wrote:
> Fixes:
>
> 8146138 jshell tool: add /help <command>
> 8147495 jshell tool: correctly handle arguments on /seteditor command
> 8147886 jshell tool: commands don't allow reference to start-up or
> explicit id of dropped/failed snippets
> 8147887 jshell tool: /list start -- fails
> 8147898 jshell tool: /reload quiet -- should quiet echo
>
> Webrev:
>
>    http://cr.openjdk.java.net/~rfield/8146138v0.patch/
>
> Thanks,
> Robert
>