RFR 8148316: jshell tool: Configurable output format
ShinyaYoshida
bitterfoxc at gmail.com
Thu Feb 11 06:48:33 UTC 2016
Hi Robert,
This feature is very amazing!!!
This will be really helpful to internationalize!
Just trivial comment:
You've updated the copyright in JShellTools.java excepting the others.
Don't you update it in the other files?
shinyafox(Shinya Yoshida)
2016-02-11 4:58 GMT+09:00 Robert Field <robert.field at oracle.com>:
> I got feedback from the team that the configuration formats were cryptic
> and insufficiently expressive.
>
> Here is a re-write,,, ...please review
>
> Bugs (the second (unrelated) bug was discovered and fixed in the process
> of testing):
> https://bugs.openjdk.java.net/browse/JDK-8148316 <
> https://bugs.openjdk.java.net/browse/JDK-8148316>
> https://bugs.openjdk.java.net/browse/JDK-8149524 <
> https://bugs.openjdk.java.net/browse/JDK-8149524>
>
> Webrev:
> http://cr.openjdk.java.net/~rfield/8148316v7.webrev/ <
> http://cr.openjdk.java.net/~rfield/8148316v7.webrev/>
>
> An example output configuration (Open with /open):
> http://cr.openjdk.java.net/~rfield/formats/arrowResultNlMeta.jsh <
> http://cr.openjdk.java.net/~rfield/formats/arrowResultNlMeta.jsh>
>
> Thanks,
> Robert
>
>
> > On Jan 28, 2016, at 8:23 PM, Robert Field <robert.field at oracle.com>
> wrote:
> >
> > Bug:
> > https://bugs.openjdk.java.net/browse/JDK-8148316
> >
> > Webrev:
> > http://cr.openjdk.java.net/~rfield/8148316v1.webrev/
> >
> > Some example output configurations (Open with /open):
> > http://cr.openjdk.java.net/~rfield/formats/arrowResultNlMeta.jsh
> > http://cr.openjdk.java.net/~rfield/formats/dan.jsh
> > http://cr.openjdk.java.net/~rfield/formats/brian.jsh
> >
> > -Robert
> >
>
>
More information about the kulla-dev
mailing list