RFR for JDK 9 fix of JDK-8150427: Demote ToolReloadTest.java and mark as intermittently failing

Jonathan Gibbons jonathan.gibbons at oracle.com
Tue Feb 23 18:50:28 UTC 2016


Looks good to me, although I would recommend placing the @key tag 
earlier in the test description (before or after @library) as a matter 
of style.

-- Jon


On 02/23/2016 10:10 AM, joe darcy wrote:
> Hello,
>
> The test
>
>     jdk/jshell/ToolReloadTest.java
>
> has been seen to intermittently fail (JDK-8149046). Until that failure 
> is addressed, the test should be marked as "@key intermittent" and the 
> test should be demoted from tier 1 to tier 2.
>
> Patch below.
>
> Thanks,
>
> -Joe
>
>
> diff -r 3cdfbbdb6f61 test/TEST.groups
> --- a/test/TEST.groups    Mon Feb 22 16:17:25 2016 -0800
> +++ b/test/TEST.groups    Tue Feb 23 09:52:43 2016 -0800
> @@ -22,15 +22,17 @@
>
>  # Tiered testing definitions
>
> -# All langtools tests are tier 1.
> +# (Nearly) all langtools tests are tier 1.
>  tier1 = \
>      com \
>      jdk \
>      lib \
> -    tools
> +    tools \
> +    -jdk/jshell/ToolReloadTest.java
>
> -# No langtools tests are tier 2.
> -tier2 =
> +# (Almost) No langtools tests are tier 2.
> +tier2 = \
> +    jdk/jshell/ToolReloadTest.java
>
>  # No langtools tests are tier 3 either.
>  tier3 =
> diff -r 3cdfbbdb6f61 test/jdk/jshell/ToolReloadTest.java
> --- a/test/jdk/jshell/ToolReloadTest.java    Mon Feb 22 16:17:25 2016 
> -0800
> +++ b/test/jdk/jshell/ToolReloadTest.java    Tue Feb 23 09:52:43 2016 
> -0800
> @@ -31,6 +31,7 @@
>   * @library /tools/lib
>   * @build KullaTesting TestingInputStream ToolBox Compiler
>   * @run testng ToolReloadTest
> + * @key intermittent
>   */
>
>  import java.nio.file.Path;
>



More information about the kulla-dev mailing list