RFR 8081845: JShell: Need way to refresh relative to external state

Jan Lahoda jan.lahoda at oracle.com
Thu Jan 7 22:00:57 UTC 2016


On 7.1.2016 17:20, Robert Field wrote:
> Thank you Jan.
>
> Taking too long is a real concern.  Anything ctrl-c'ed when initially
> entered will not be recorded in replay history.
>
> Any side-effects should be the same the second time.  Or, an I missing
> your meaning?

I was thinking of "external" side-effects, like creating or deleting a 
file. I think practice will show if (and when) that will be causing 
problems (i.e. to what degree it is problematic to do these the second 
time).

Jan

>
> Thanks,
> Robert
>
>
>
> On January 7, 2016 4:34:55 AM Jan Lahoda <jan.lahoda at oracle.com> wrote:
>
>> Seems OK to me. I wonder if we will have problems with snippets taking
>> too long to execute, or with side-effects, but we will find out.
>>
>> A nit:
>>
>> In @@ -250,10 +261,16 @@:
>> // Read replay history from last jshell session into previoius history
>> ->
>> // Read replay history from last jshell session into previous history
>>
>> Jan
>>
>> On 31.12.2015 07:55, Robert Field wrote:
>>> JBS Issue: https://bugs.openjdk.java.net/browse/JDK-8081845
>>> Webrev: http://cr.openjdk.java.net/~rfield/8081845v1/
>>>
>
>


More information about the kulla-dev mailing list