From robert.field at oracle.com Thu Jul 7 07:07:14 2016 From: robert.field at oracle.com (Robert Field) Date: Thu, 07 Jul 2016 00:07:14 -0700 Subject: RFR 8160935: JShell Message-ID: <577DFFA2.8060109@oracle.com> Bug: https://bugs.openjdk.java.net/browse/JDK-8160935 Webrev: http://cr.openjdk.java.net/~rfield/8160935v0.webrev/ From jan.lahoda at oracle.com Thu Jul 7 07:22:25 2016 From: jan.lahoda at oracle.com (Jan Lahoda) Date: Thu, 7 Jul 2016 09:22:25 +0200 Subject: RFR 8160935: JShell In-Reply-To: <577DFFA2.8060109@oracle.com> References: <577DFFA2.8060109@oracle.com> Message-ID: <577E0331.1000902@oracle.com> Looks good! Jan On 7.7.2016 09:07, Robert Field wrote: > Bug: > https://bugs.openjdk.java.net/browse/JDK-8160935 > > Webrev: > http://cr.openjdk.java.net/~rfield/8160935v0.webrev/ > From robert.field at oracle.com Wed Jul 13 05:52:32 2016 From: robert.field at oracle.com (Robert Field) Date: Tue, 12 Jul 2016 22:52:32 -0700 Subject: RFR 8160127, et. al.: JShell API: ExecutionControl implementation support In-Reply-To: <577337A9.8000204@oracle.com> References: <577337A9.8000204@oracle.com> Message-ID: <5785D720.9050100@oracle.com> Responding to feedback that the originally produced API was huge, and the suggestion of remote-streamed symmetry/forwarding, I have rewritten the code. The remote agent code was part of this rewrite and is now also included. Please review -- Bugs: JShell API: extract abstract JDI and abstract streaming implementations of ExecutionControl https://bugs.openjdk.java.net/browse/JDK-8160127 JShell API: Reorganize execution support code into jdk.jshell.execution (previously sent for review, and combined here) https://bugs.openjdk.java.net/browse/JDK-8159935 JShell API: extract abstract streaming remote agent https://bugs.openjdk.java.net/browse/JDK-8160128 Parent bug: https://bugs.openjdk.java.net/browse/JDK-8159118 API: http://cr.openjdk.java.net/~rfield/jshell_8160127v1/ Specifically -- http://cr.openjdk.java.net/~rfield/jshell_8160127v1/jdk/jshell/execution/package-summary.html http://cr.openjdk.java.net/~rfield/jshell_8160127v1/jdk/jshell/spi/package-summary.html Webrev: http://cr.openjdk.java.net/~rfield/8160127v1.webrev/ Thanks, Robert From robert.field at oracle.com Fri Jul 15 07:31:54 2016 From: robert.field at oracle.com (Robert Field) Date: Fri, 15 Jul 2016 00:31:54 -0700 Subject: RFR 8160127, et. al.: JShell API: ExecutionControl implementation support In-Reply-To: <5785D720.9050100@oracle.com> References: <577337A9.8000204@oracle.com> <5785D720.9050100@oracle.com> Message-ID: <5788916A.6050308@oracle.com> In response to concerns about the logging mechanism, it has been removed. Leaving room the standard logging to be used. In response to concerns about dependencies on jdk,jshell, ExecutionEnv.state() has been removed (this is possible because of the JShell-specific logging was removed). In response to extensibility concerns, there is now ExecutionControl.extensionCommand(), a new exception ExecutionControl.NotImplementedException, and RemoteCodes returns with string commands. In response to the desire to have additional multiplexed channels and to multiplexing, System.out and System.err are no longer special-cased, and now symmetric stream maps configure both sides. Bugs: JShell API: extract abstract JDI and abstract streaming implementations of ExecutionControl https://bugs.openjdk.java.net/browse/JDK-8160127 JShell API: Reorganize execution support code into jdk.jshell.execution (previously sent for review, and combined here) https://bugs.openjdk.java.net/browse/JDK-8159935 JShell API: extract abstract streaming remote agent https://bugs.openjdk.java.net/browse/JDK-8160128 Parent bug: https://bugs.openjdk.java.net/browse/JDK-8159118 API: http://cr.openjdk.java.net/~rfield/jshell_8160127v2/ Specifically -- http://cr.openjdk.java.net/~rfield/jshell_8160127v2/jdk/jshell/execution/package-summary.html http://cr.openjdk.java.net/~rfield/jshell_8160127v2/jdk/jshell/spi/package-summary.html Webrev: http://cr.openjdk.java.net/~rfield/8160127v2.webrev/ Thanks, Robert From jan.lahoda at oracle.com Fri Jul 15 20:05:40 2016 From: jan.lahoda at oracle.com (Jan Lahoda) Date: Fri, 15 Jul 2016 22:05:40 +0200 Subject: RFR 8160127, et. al.: JShell API: ExecutionControl implementation support In-Reply-To: <5788916A.6050308@oracle.com> References: <577337A9.8000204@oracle.com> <5785D720.9050100@oracle.com> <5788916A.6050308@oracle.com> Message-ID: <57894214.4050109@oracle.com> Seems reasonable to me. Jan On 15.7.2016 09:31, Robert Field wrote: > In response to concerns about the logging mechanism, it has been > removed. Leaving room the standard logging to be used. > In response to concerns about dependencies on jdk,jshell, > ExecutionEnv.state() has been removed (this is possible because of the > JShell-specific logging was removed). > In response to extensibility concerns, there is now > ExecutionControl.extensionCommand(), a new exception > ExecutionControl.NotImplementedException, and RemoteCodes returns with > string commands. > In response to the desire to have additional multiplexed channels and to > multiplexing, System.out and System.err are no longer special-cased, and > now symmetric stream maps configure both sides. > > Bugs: > > JShell API: extract abstract JDI and abstract streaming > implementations of ExecutionControl > https://bugs.openjdk.java.net/browse/JDK-8160127 > > JShell API: Reorganize execution support code into > jdk.jshell.execution (previously sent for review, and combined here) > https://bugs.openjdk.java.net/browse/JDK-8159935 > > JShell API: extract abstract streaming remote agent > https://bugs.openjdk.java.net/browse/JDK-8160128 > > Parent bug: > > https://bugs.openjdk.java.net/browse/JDK-8159118 > > API: > > http://cr.openjdk.java.net/~rfield/jshell_8160127v2/ > > Specifically -- > http://cr.openjdk.java.net/~rfield/jshell_8160127v2/jdk/jshell/execution/package-summary.html > > http://cr.openjdk.java.net/~rfield/jshell_8160127v2/jdk/jshell/spi/package-summary.html > > > Webrev: > > http://cr.openjdk.java.net/~rfield/8160127v2.webrev/ > > > Thanks, > Robert From robert.field at oracle.com Wed Jul 20 06:40:01 2016 From: robert.field at oracle.com (Robert Field) Date: Tue, 19 Jul 2016 23:40:01 -0700 Subject: RFR 8160127, et. al.: JShell API: ExecutionControl implementation support In-Reply-To: <5785D720.9050100@oracle.com> References: <577337A9.8000204@oracle.com> <5785D720.9050100@oracle.com> Message-ID: <578F1CC1.9060909@oracle.com> After more review comments -- Since logging was removed, back-out debugging changes. ExecutionControl: Add doc. Add serialVersionUID on exceptions. Encapsulate fields in ExecutionControl.ClassBytecodes. Optionally configure DirectExecutionControl and its subclasses for alternate loader mechanisms with LoaderDelegate. JDIExecutionControl: Hide field with map from class name to ReferenceType. Add testing for aux channel. Previous code review was v2, this is v4. Please review -- Bugs: JShell API: extract abstract JDI and abstract streaming implementations of ExecutionControl https://bugs.openjdk.java.net/browse/JDK-8160127 JShell API: Reorganize execution support code into jdk.jshell.execution (previously sent for review, and combined here) https://bugs.openjdk.java.net/browse/JDK-8159935 JShell API: extract abstract streaming remote agent https://bugs.openjdk.java.net/browse/JDK-8160128 JShell API: Configurable invocation mechanism https://bugs.openjdk.java.net/browse/JDK-8159122 Parent bug: https://bugs.openjdk.java.net/browse/JDK-8159118 API: http://cr.openjdk.java.net/~rfield/jshell_8160127v4/ Specifically -- http://cr.openjdk.java.net/~rfield/jshell_8160127v4/jdk/jshell/execution/package-summary.html http://cr.openjdk.java.net/~rfield/jshell_8160127v4/jdk/jshell/spi/package-summary.html Specdiff (v4): http://cr.openjdk.java.net/~rfield/8160127v4.specdiff/overview-summary.html Specdiff delta (v2 to v4): Changes, seee below. http://cr.openjdk.java.net/~rfield/8160127v2v4.specdiff/overview-summary.html Webrev: http://cr.openjdk.java.net/~rfield/8160127v4.webrev/ Webrev delta (v2 to v4): http://cr.openjdk.java.net/~rfield/8160127v2v4%2cwebrev/ Thanks, Robert From jan.lahoda at oracle.com Wed Jul 20 19:27:08 2016 From: jan.lahoda at oracle.com (Jan Lahoda) Date: Wed, 20 Jul 2016 21:27:08 +0200 Subject: RFR 8160127, et. al.: JShell API: ExecutionControl implementation support In-Reply-To: <578F1CC1.9060909@oracle.com> References: <577337A9.8000204@oracle.com> <5785D720.9050100@oracle.com> <578F1CC1.9060909@oracle.com> Message-ID: <578FD08C.9050903@oracle.com> Seems OK to me. Jan On 20.7.2016 08:40, Robert Field wrote: > After more review comments -- > Since logging was removed, back-out debugging changes. > ExecutionControl: Add doc. Add serialVersionUID on exceptions. > Encapsulate fields in ExecutionControl.ClassBytecodes. > Optionally configure DirectExecutionControl and its subclasses for > alternate loader mechanisms with LoaderDelegate. > JDIExecutionControl: Hide field with map from class name to > ReferenceType. > Add testing for aux channel. > > Previous code review was v2, this is v4. Please review -- > > Bugs: > > JShell API: extract abstract JDI and abstract streaming > implementations of ExecutionControl > https://bugs.openjdk.java.net/browse/JDK-8160127 > > JShell API: Reorganize execution support code into > jdk.jshell.execution (previously sent for review, and combined here) > https://bugs.openjdk.java.net/browse/JDK-8159935 > > JShell API: extract abstract streaming remote agent > https://bugs.openjdk.java.net/browse/JDK-8160128 > > JShell API: Configurable invocation mechanism > https://bugs.openjdk.java.net/browse/JDK-8159122 > > Parent bug: > > https://bugs.openjdk.java.net/browse/JDK-8159118 > > API: > > http://cr.openjdk.java.net/~rfield/jshell_8160127v4/ > > Specifically -- > http://cr.openjdk.java.net/~rfield/jshell_8160127v4/jdk/jshell/execution/package-summary.html > > http://cr.openjdk.java.net/~rfield/jshell_8160127v4/jdk/jshell/spi/package-summary.html > > > Specdiff (v4): > > http://cr.openjdk.java.net/~rfield/8160127v4.specdiff/overview-summary.html > > Specdiff delta (v2 to v4): Changes, seee below. > > http://cr.openjdk.java.net/~rfield/8160127v2v4.specdiff/overview-summary.html > > > Webrev: > > http://cr.openjdk.java.net/~rfield/8160127v4.webrev/ > > Webrev delta (v2 to v4): > > http://cr.openjdk.java.net/~rfield/8160127v2v4%2cwebrev/ > > Thanks, > Robert > From iris.clark at oracle.com Wed Jul 20 20:10:33 2016 From: iris.clark at oracle.com (Iris Clark) Date: Wed, 20 Jul 2016 13:10:33 -0700 (PDT) Subject: RFR(s) 8161236: Runtime.Version.{compareTo, equals}IgnoreOpt should be renamed Message-ID: Hi. Please review changes in jdk and langtools (module jdk.jshell) to address the following bug: 8161236: Runtime.Version.{compareTo,equals}IgnoreOpt should be renamed https://bugs.openjdk.java.net/browse/JDK-8161236 Webrev: http://cr.openjdk.java.net/~iris/verona/8161236/webrev.0/ We update the method declarations to replace the token "Opt" with "Optional", thus aligning the method names with the associated getter, Runtime.Version.optional(). Specification references to those methods and any uses of the methods were also updated. JPRT runs (testsets hotspot and pit) show no failures related to these changes. A CCC request is in flight. Regards, Iris From robert.field at oracle.com Thu Jul 21 01:15:36 2016 From: robert.field at oracle.com (Robert Field) Date: Wed, 20 Jul 2016 18:15:36 -0700 Subject: RFR(s) 8161236: Runtime.Version.{compareTo, equals}IgnoreOpt should be renamed In-Reply-To: References: Message-ID: <57902238.8090207@oracle.com> Thumbs up on JShell change. -Robert On 07/20/16 13:10, Iris Clark wrote: > Hi. > > > > Please review changes in jdk and langtools (module jdk.jshell) to address the following bug: > > > > 8161236: Runtime.Version.{compareTo,equals}IgnoreOpt should be renamed > > https://bugs.openjdk.java.net/browse/JDK-8161236 > > > > Webrev: > > > > http://cr.openjdk.java.net/~iris/verona/8161236/webrev.0/ > > > > We update the method declarations to replace the token "Opt" with "Optional", thus aligning the method names with the associated getter, Runtime.Version.optional(). Specification references to those methods and any uses of the methods were also updated. > > > > JPRT runs (testsets hotspot and pit) show no failures related to these changes. A CCC request is in flight. > > > > Regards, > > Iris > > From iris.clark at oracle.com Thu Jul 21 04:06:37 2016 From: iris.clark at oracle.com (Iris Clark) Date: Wed, 20 Jul 2016 21:06:37 -0700 (PDT) Subject: RFR(s) 8161236: Runtime.Version.{compareTo, equals}IgnoreOpt should be renamed In-Reply-To: <57902238.8090207@oracle.com> References: <57902238.8090207@oracle.com> Message-ID: <7530576c-f55e-4b17-8d66-febecfe8e056@default> Hi, Robert. Thanks for Reviewing! iris -----Original Message----- From: Robert Field Sent: Wednesday, July 20, 2016 6:16 PM To: Iris Clark; Kumar Srinivasan; Java Core Libs; compiler-dev at openjdk.java.net; kulla-dev at openjdk.java.net Subject: Re: RFR(s) 8161236: Runtime.Version.{compareTo, equals}IgnoreOpt should be renamed Thumbs up on JShell change. -Robert On 07/20/16 13:10, Iris Clark wrote: > Hi. > > > > Please review changes in jdk and langtools (module jdk.jshell) to address the following bug: > > > > 8161236: Runtime.Version.{compareTo,equals}IgnoreOpt should be renamed > > https://bugs.openjdk.java.net/browse/JDK-8161236 > > > > Webrev: > > > > http://cr.openjdk.java.net/~iris/verona/8161236/webrev.0/ > > > > We update the method declarations to replace the token "Opt" with "Optional", thus aligning the method names with the associated getter, Runtime.Version.optional(). Specification references to those methods and any uses of the methods were also updated. > > > > JPRT runs (testsets hotspot and pit) show no failures related to these changes. A CCC request is in flight. > > > > Regards, > > Iris > > From Alan.Bateman at oracle.com Thu Jul 21 11:36:05 2016 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Thu, 21 Jul 2016 12:36:05 +0100 Subject: RFR(s) 8161236: Runtime.Version.{compareTo, equals}IgnoreOpt should be renamed In-Reply-To: References: Message-ID: <563b5669-dc42-599c-ff87-b6eac3851f09@oracle.com> On 20/07/2016 21:10, Iris Clark wrote: > Hi. > > > > Please review changes in jdk and langtools (module jdk.jshell) to address the following bug: > > The rename looks okay to me. -Alan From iris.clark at oracle.com Thu Jul 21 16:15:33 2016 From: iris.clark at oracle.com (Iris Clark) Date: Thu, 21 Jul 2016 09:15:33 -0700 (PDT) Subject: RFR(s) 8161236: Runtime.Version.{compareTo, equals}IgnoreOpt should be renamed In-Reply-To: <563b5669-dc42-599c-ff87-b6eac3851f09@oracle.com> References: <563b5669-dc42-599c-ff87-b6eac3851f09@oracle.com> Message-ID: <3991de58-1791-46c9-ba8a-76100153ca9f@default> Hi, Alan. Thanks! iris -----Original Message----- From: Alan Bateman Sent: Thursday, July 21, 2016 4:36 AM To: Iris Clark; Kumar Srinivasan; Java Core Libs; compiler-dev at openjdk.java.net; kulla-dev at openjdk.java.net Subject: Re: RFR(s) 8161236: Runtime.Version.{compareTo, equals}IgnoreOpt should be renamed On 20/07/2016 21:10, Iris Clark wrote: > Hi. > > > > Please review changes in jdk and langtools (module jdk.jshell) to address the following bug: > > The rename looks okay to me. -Alan From jan.lahoda at oracle.com Thu Jul 21 16:22:45 2016 From: jan.lahoda at oracle.com (Jan Lahoda) Date: Thu, 21 Jul 2016 18:22:45 +0200 Subject: RFR(xs) 8162255: Alt-Enter v/Alt-Enter i not working on some terminals Message-ID: <5790F6D5.1000305@oracle.com> Hi, ConsoleIOContext currently contains a code sequence for Alt-Enter. Some terminals appear to send a different code sequence for the shortcut. So I propose to add this code sequence to ConsoleIOContext as well. Bug: https://bugs.openjdk.java.net/browse/JDK-8162255 Webrev: http://cr.openjdk.java.net/~jlahoda/8162255/webrev.00/ Thanks for any feedback, Jan From robert.field at oracle.com Thu Jul 21 16:45:10 2016 From: robert.field at oracle.com (Robert Field) Date: Thu, 21 Jul 2016 09:45:10 -0700 Subject: RFR(xs) 8162255: Alt-Enter v/Alt-Enter i not working on some terminals In-Reply-To: <5790F6D5.1000305@oracle.com> References: <5790F6D5.1000305@oracle.com> Message-ID: <1560e58b5f0.2784.4011f3a8741ca2aabce58b8b81f42d24@oracle.com> Thumbs up. Robert On July 21, 2016 9:23:06 AM Jan Lahoda wrote: > Hi, > > ConsoleIOContext currently contains a code sequence for Alt-Enter. > Some terminals appear to send a different code sequence for the > shortcut. So I propose to add this code sequence to ConsoleIOContext as > well. > > Bug: > https://bugs.openjdk.java.net/browse/JDK-8162255 > > Webrev: > http://cr.openjdk.java.net/~jlahoda/8162255/webrev.00/ > > Thanks for any feedback, > Jan From iris.clark at oracle.com Thu Jul 21 21:01:52 2016 From: iris.clark at oracle.com (Iris Clark) Date: Thu, 21 Jul 2016 14:01:52 -0700 (PDT) Subject: RFR(s) 8161236: Runtime.Version.{compareTo, equals}IgnoreOpt should be renamed In-Reply-To: References: Message-ID: Hi, Kumar. Thank you very much for pushing the changesets to resolve this bug! Regards. iris From: Iris Clark Sent: Wednesday, July 20, 2016 1:11 PM To: Kumar Srinivasan; Java Core Libs; compiler-dev at openjdk.java.net; kulla-dev at openjdk.java.net Subject: RFR(s) 8161236: Runtime.Version.{compareTo, equals}IgnoreOpt should be renamed Hi. Please review changes in jdk and langtools (module jdk.jshell) to address the following bug: 8161236: Runtime.Version.{compareTo,equals}IgnoreOpt should be renamed https://bugs.openjdk.java.net/browse/JDK-8161236 Webrev: http://cr.openjdk.java.net/~iris/verona/8161236/webrev.0/ We update the method declarations to replace the token "Opt" with "Optional", thus aligning the method names with the associated getter, Runtime.Version.optional(). Specification references to those methods and any uses of the methods were also updated. JPRT runs (testsets hotspot and pit) show no failures related to these changes. A CCC request is in flight. Regards, Iris From samuelmarks at gmail.com Fri Jul 29 07:34:34 2016 From: samuelmarks at gmail.com (Samuel Marks) Date: Fri, 29 Jul 2016 17:34:34 +1000 Subject: Fails to configure with Java 9 ea (Early Access) Message-ID: Error: configure: Found potential Boot JDK using configure arguments configure: Potential Boot JDK found at /opt/Java/jdk-9 is incorrect JDK version (java version "9-ea"); ignoring configure: (Your Boot JDK must be version 8 or 9) configure: error: The path given by --with-boot-jdk does not contain a valid Boot JDK Here's a fix (also attached, not sure what the protocol is): # HG changeset patch # User Samuel Marks # Date 1469777474 -36000 # Fri Jul 29 17:31:14 2016 +1000 # Node ID 9268348574206a8487901c8e8a1ea15987709521 # Parent 77a1e3986f77f6e9d1037f4de8296d927ef12ac4 New version check routine to handle Java 9 Early Access release diff -r 77a1e3986f77 -r 926834857420 common/autoconf/boot-jdk.m4 --- a/common/autoconf/boot-jdk.m4 Sat Aug 22 00:47:29 2015 -0700 +++ b/common/autoconf/boot-jdk.m4 Fri Jul 29 17:31:14 2016 +1000 @@ -74,11 +74,12 @@ BOOT_JDK_FOUND=no else # Oh, this is looking good! We probably have found a proper JDK. Is it the correct version? - BOOT_JDK_VERSION=`"$BOOT_JDK/bin/java" -version 2>&1 | head -n 1` + BOOT_JDK_VERSION=`"$BOOT_JDK/bin/java" -version 2>&1 | awk '/version/{print $NF}'` + BOOT_JDK_VERSION="${BOOT_JDK_VERSION:1:3}" + CORRECT_VERSIONS=(1.8 1.9 9 9-e) # Extra M4 quote needed to protect [] in grep expression. - [FOUND_CORRECT_VERSION=`echo $BOOT_JDK_VERSION | grep '\"1\.[89]\.'`] - if test "x$FOUND_CORRECT_VERSION" = x; then + if [[ ! " ${CORRECT_VERSIONS[*]} " == *" $BOOT_JDK_VERSION "* ]]; then AC_MSG_NOTICE([Potential Boot JDK found at $BOOT_JDK is incorrect JDK version ($BOOT_JDK_VERSION); ignoring]) AC_MSG_NOTICE([(Your Boot JDK must be version 8 or 9)]) BOOT_JDK_FOUND=no Samuel Marks http://linkedin.com/in/samuelmarks -------------- next part -------------- A non-text attachment was scrubbed... Name: patch.patch Type: text/x-patch Size: 1437 bytes Desc: not available URL: From bitterfoxc at gmail.com Fri Jul 29 07:44:06 2016 From: bitterfoxc at gmail.com (ShinyaYoshida) Date: Fri, 29 Jul 2016 16:44:06 +0900 Subject: Fails to configure with Java 9 ea (Early Access) In-Reply-To: References: Message-ID: Hi Samuel, Thank you for your contributing, but it's not the correct mailing list. This mailing list is for developing jshell, the Java REPL tool. The suitable mailing list is build-dev. Please send this to build-dev. Thanks, shinyafox(Shinya Yoshida) 2016/07/29 ??4:34 "Samuel Marks" : > Error: > configure: Found potential Boot JDK using configure arguments > configure: Potential Boot JDK found at /opt/Java/jdk-9 is incorrect JDK > version (java version "9-ea"); ignoring > configure: (Your Boot JDK must be version 8 or 9) > configure: error: The path given by --with-boot-jdk does not contain a > valid Boot JDK > > Here's a fix (also attached, not sure what the protocol is): > > # HG changeset patch > # User Samuel Marks > # Date 1469777474 -36000 > # Fri Jul 29 17:31:14 2016 +1000 > # Node ID 9268348574206a8487901c8e8a1ea15987709521 > # Parent 77a1e3986f77f6e9d1037f4de8296d927ef12ac4 > New version check routine to handle Java 9 Early Access release > > diff -r 77a1e3986f77 -r 926834857420 common/autoconf/boot-jdk.m4 > --- a/common/autoconf/boot-jdk.m4 Sat Aug 22 00:47:29 2015 -0700 > +++ b/common/autoconf/boot-jdk.m4 Fri Jul 29 17:31:14 2016 +1000 > @@ -74,11 +74,12 @@ > BOOT_JDK_FOUND=no > else > # Oh, this is looking good! We probably have found a proper JDK. > Is it the correct version? > - BOOT_JDK_VERSION=`"$BOOT_JDK/bin/java" -version 2>&1 | head -n > 1` > + BOOT_JDK_VERSION=`"$BOOT_JDK/bin/java" -version 2>&1 | awk > '/version/{print $NF}'` > + BOOT_JDK_VERSION="${BOOT_JDK_VERSION:1:3}" > + CORRECT_VERSIONS=(1.8 1.9 9 9-e) > > # Extra M4 quote needed to protect [] in grep expression. > - [FOUND_CORRECT_VERSION=`echo $BOOT_JDK_VERSION | grep > '\"1\.[89]\.'`] > - if test "x$FOUND_CORRECT_VERSION" = x; then > + if [[ ! " ${CORRECT_VERSIONS[*]} " == *" $BOOT_JDK_VERSION "* > ]]; then > AC_MSG_NOTICE([Potential Boot JDK found at $BOOT_JDK is > incorrect JDK version ($BOOT_JDK_VERSION); ignoring]) > AC_MSG_NOTICE([(Your Boot JDK must be version 8 or 9)]) > BOOT_JDK_FOUND=no > > > Samuel Marks > http://linkedin.com/in/samuelmarks > From bitterfoxc at gmail.com Fri Jul 29 08:12:46 2016 From: bitterfoxc at gmail.com (ShinyaYoshida) Date: Fri, 29 Jul 2016 17:12:46 +0900 Subject: kulla fails to configure with Java 9 ea (Early Access) In-Reply-To: References: Message-ID: Hi Samuel, thank you for resending. Oops, let me confirm one thing please. You got this error on a repository hosted on kulla-dev, right? If so, unfortunately it isn't under maintaining because it already merged to jdk9-dev. Please confirm that you still get this error on jdk9-dev and your patch works well on it. Regards, shinyafox(Shinya Yoshida) 2016/07/29 ??4:55 "Samuel Marks" : > Error: > configure: Found potential Boot JDK using configure arguments > configure: Potential Boot JDK found at /opt/Java/jdk-9 is incorrect JDK > version (java version "9-ea"); ignoring > configure: (Your Boot JDK must be version 8 or 9) > configure: error: The path given by --with-boot-jdk does not contain a > valid Boot JDK > > Here's a fix to the kulla repository (also attached, not sure what the > protocol is): > > # HG changeset patch > # User Samuel Marks > # Date 1469777474 -36000 > # Fri Jul 29 17:31:14 2016 +1000 > # Node ID 9268348574206a8487901c8e8a1ea15987709521 > # Parent 77a1e3986f77f6e9d1037f4de8296d927ef12ac4 > New version check routine to handle Java 9 Early Access release > > diff -r 77a1e3986f77 -r 926834857420 common/autoconf/boot-jdk.m4 > --- a/common/autoconf/boot-jdk.m4 Sat Aug 22 00:47:29 2015 -0700 > +++ b/common/autoconf/boot-jdk.m4 Fri Jul 29 17:31:14 2016 +1000 > @@ -74,11 +74,12 @@ > BOOT_JDK_FOUND=no > else > # Oh, this is looking good! We probably have found a proper JDK. > Is it the correct version? > - BOOT_JDK_VERSION=`"$BOOT_JDK/bin/java" -version 2>&1 | head -n > 1` > + BOOT_JDK_VERSION=`"$BOOT_JDK/bin/java" -version 2>&1 | awk > '/version/{print $NF}'` > + BOOT_JDK_VERSION="${BOOT_JDK_VERSION:1:3}" > + CORRECT_VERSIONS=(1.8 1.9 9 9-e) > > # Extra M4 quote needed to protect [] in grep expression. > - [FOUND_CORRECT_VERSION=`echo $BOOT_JDK_VERSION | grep > '\"1\.[89]\.'`] > - if test "x$FOUND_CORRECT_VERSION" = x; then > + if [[ ! " ${CORRECT_VERSIONS[*]} " == *" $BOOT_JDK_VERSION "* > ]]; then > AC_MSG_NOTICE([Potential Boot JDK found at $BOOT_JDK is > incorrect JDK version ($BOOT_JDK_VERSION); ignoring]) > AC_MSG_NOTICE([(Your Boot JDK must be version 8 or 9)]) > BOOT_JDK_FOUND=no > > Samuel Marks > http://linkedin.com/in/samuelmarks > > BTW: I posted in kulla-dev but they told me to post here - > http://mail.openjdk.java.net/pipermail/kulla-dev/2016-July/001508.html > From jonathan.gibbons at oracle.com Fri Jul 29 19:44:13 2016 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Fri, 29 Jul 2016 12:44:13 -0700 Subject: jshell (tests?) leaking files in /tmp Message-ID: <579BB20D.9060306@oracle.com> My /tmp is accumulating jshell files: $ find /tmp/jshell* /tmp/jshelltemp1044549827386632150 /tmp/jshelltemp1044549827386632150/8011562224044845728.edit /tmp/jshelltemp1047969916921684187 /tmp/jshelltemp1047969916921684187/1740671090630915795.edit /tmp/jshelltemp1072678409055720780 /tmp/jshelltemp1072678409055720780/978408699063547197.edit /tmp/jshelltemp1200545436603537750 /tmp/jshelltemp1200545436603537750/3390705712185362355.edit /tmp/jshelltemp1221162966070216464 /tmp/jshelltemp1221162966070216464/3081222915116288162.edit /tmp/jshelltemp1425582075044687363 /tmp/jshelltemp1425582075044687363/4082709690184420251.edit /tmp/jshelltemp1577033095144892398 /tmp/jshelltemp1577033095144892398/9081427157952395244.edit /tmp/jshelltemp1585036544870564328 /tmp/jshelltemp1585036544870564328/3906837717961713151.edit /tmp/jshelltemp165895593330514486 /tmp/jshelltemp165895593330514486/6627843380470403643.edit /tmp/jshelltemp1833109810049396364 /tmp/jshelltemp1833109810049396364/517769421906389157.edit /tmp/jshelltemp2041981097096951060 /tmp/jshelltemp2041981097096951060/2349577263460706006.edit /tmp/jshelltemp2193900651454655061 /tmp/jshelltemp2193900651454655061/6384782619469415234.edit /tmp/jshelltemp2234949382818285124 /tmp/jshelltemp2234949382818285124/4834457107790499447.edit /tmp/jshelltemp2296337736965199344 /tmp/jshelltemp2296337736965199344/8826222356240547610.edit /tmp/jshelltemp2345658105656559252 /tmp/jshelltemp2345658105656559252/6729333722014852729.edit /tmp/jshelltemp2468675356543856110 /tmp/jshelltemp2468675356543856110/6621846833826280297.edit /tmp/jshelltemp2504345118557203640 /tmp/jshelltemp2504345118557203640/5097858842709809254.edit /tmp/jshelltemp2595239917647196066 /tmp/jshelltemp2595239917647196066/4410162140727614450.edit /tmp/jshelltemp2668148898346441797 /tmp/jshelltemp2668148898346441797/1660414210153626169.edit /tmp/jshelltemp3514984560124468983 /tmp/jshelltemp3514984560124468983/6131864124091385623.edit /tmp/jshelltemp3562125506660912173 /tmp/jshelltemp3562125506660912173/8887290599369872073.edit /tmp/jshelltemp40589362697391818 /tmp/jshelltemp40589362697391818/8822906394660574353.edit /tmp/jshelltemp4387371979722467975 /tmp/jshelltemp4387371979722467975/7249033605230168031.edit /tmp/jshelltemp4715020457318511491 /tmp/jshelltemp4715020457318511491/4636728652227855346.edit /tmp/jshelltemp52332485773094168 /tmp/jshelltemp52332485773094168/1277048994347896757.edit /tmp/jshelltemp5278128846699884471 /tmp/jshelltemp5278128846699884471/44922152761642381.edit /tmp/jshelltemp5320120409750616204 /tmp/jshelltemp5320120409750616204/24459148772882266.edit /tmp/jshelltemp5534152442553977652 /tmp/jshelltemp5534152442553977652/8186176305757939505.edit /tmp/jshelltemp5623564536996825207 /tmp/jshelltemp5623564536996825207/9045016579988583399.edit /tmp/jshelltemp5700044225140491973 /tmp/jshelltemp5700044225140491973/3188060456352696621.edit /tmp/jshelltemp6324874596657398893 /tmp/jshelltemp6324874596657398893/3179325677151331223.edit /tmp/jshelltemp6808171130698006683 /tmp/jshelltemp6808171130698006683/319127357748973046.edit /tmp/jshelltemp7001485162152525304 /tmp/jshelltemp7001485162152525304/9168706811139870527.edit /tmp/jshelltemp7069920922180135958 /tmp/jshelltemp7069920922180135958/8686060872597749049.edit /tmp/jshelltemp7088266688866808879 /tmp/jshelltemp7088266688866808879/6924602628004312642.edit /tmp/jshelltemp7173145703014422717 /tmp/jshelltemp7173145703014422717/4607109423377503842.edit /tmp/jshelltemp7180999435914656215 /tmp/jshelltemp7180999435914656215/5549682196654974987.edit /tmp/jshelltemp7208905856201817354 /tmp/jshelltemp7208905856201817354/6181265411604183143.edit /tmp/jshelltemp7680863956932965286 /tmp/jshelltemp7680863956932965286/4077316136930888410.edit /tmp/jshelltemp7853784893157006161 /tmp/jshelltemp7853784893157006161/5787573000355892776.edit /tmp/jshelltemp7992097935706702471 /tmp/jshelltemp7992097935706702471/1856486408875906360.edit /tmp/jshelltemp8128412259418228343 /tmp/jshelltemp8128412259418228343/5002913207029300566.edit /tmp/jshelltemp8227545996613827901 /tmp/jshelltemp8227545996613827901/3843405868953231414.edit /tmp/jshelltemp850631284448899163 /tmp/jshelltemp850631284448899163/481600313656353994.edit /tmp/jshelltemp8744516682365157187 /tmp/jshelltemp8744516682365157187/5826738179758017666.edit /tmp/jshelltemp8852008122297380391 /tmp/jshelltemp8852008122297380391/3226693345657046477.edit /tmp/jshelltemp9074215226291200769 /tmp/jshelltemp9074215226291200769/8315526298738535034.edit /tmp/jshelltemp9193145933675852815 /tmp/jshelltemp9193145933675852815/8998940437928279313.edit From samuelmarks at gmail.com Sat Jul 30 10:17:06 2016 From: samuelmarks at gmail.com (Samuel Marks) Date: Sat, 30 Jul 2016 20:17:06 +1000 Subject: kulla fails to configure with Java 9 ea (Early Access) In-Reply-To: References: Message-ID: Hmm, I could only find the one branch: http://hg.openjdk.java.net/kulla/dev/branches This is the file I edited: http://hg.openjdk.java.net/kulla/dev/file/77a1e3986f77/common/autoconf/boot-jdk.m4 Samuel Marks http://linkedin.com/in/samuelmarks On Fri, Jul 29, 2016 at 6:12 PM, ShinyaYoshida wrote: > Hi Samuel, thank you for resending. > > Oops, let me confirm one thing please. > You got this error on a repository hosted on kulla-dev, right? > > If so, unfortunately it isn't under maintaining because it already merged > to jdk9-dev. > Please confirm that you still get this error on jdk9-dev and your patch > works well on it. > > Regards, > shinyafox(Shinya Yoshida) > > 2016/07/29 ??4:55 "Samuel Marks" : > > Error: >> configure: Found potential Boot JDK using configure arguments >> configure: Potential Boot JDK found at /opt/Java/jdk-9 is incorrect JDK >> version (java version "9-ea"); ignoring >> configure: (Your Boot JDK must be version 8 or 9) >> configure: error: The path given by --with-boot-jdk does not contain a >> valid Boot JDK >> >> Here's a fix to the kulla repository (also attached, not sure what the >> protocol is): >> >> # HG changeset patch >> # User Samuel Marks >> # Date 1469777474 -36000 >> # Fri Jul 29 17:31:14 2016 +1000 >> # Node ID 9268348574206a8487901c8e8a1ea15987709521 >> # Parent 77a1e3986f77f6e9d1037f4de8296d927ef12ac4 >> New version check routine to handle Java 9 Early Access release >> >> diff -r 77a1e3986f77 -r 926834857420 common/autoconf/boot-jdk.m4 >> --- a/common/autoconf/boot-jdk.m4 Sat Aug 22 00:47:29 2015 -0700 >> +++ b/common/autoconf/boot-jdk.m4 Fri Jul 29 17:31:14 2016 +1000 >> @@ -74,11 +74,12 @@ >> BOOT_JDK_FOUND=no >> else >> # Oh, this is looking good! We probably have found a proper >> JDK. >> Is it the correct version? >> - BOOT_JDK_VERSION=`"$BOOT_JDK/bin/java" -version 2>&1 | head -n >> 1` >> + BOOT_JDK_VERSION=`"$BOOT_JDK/bin/java" -version 2>&1 | awk >> '/version/{print $NF}'` >> + BOOT_JDK_VERSION="${BOOT_JDK_VERSION:1:3}" >> + CORRECT_VERSIONS=(1.8 1.9 9 9-e) >> >> # Extra M4 quote needed to protect [] in grep expression. >> - [FOUND_CORRECT_VERSION=`echo $BOOT_JDK_VERSION | grep >> '\"1\.[89]\.'`] >> - if test "x$FOUND_CORRECT_VERSION" = x; then >> + if [[ ! " ${CORRECT_VERSIONS[*]} " == *" $BOOT_JDK_VERSION "* >> ]]; then >> AC_MSG_NOTICE([Potential Boot JDK found at $BOOT_JDK is >> incorrect JDK version ($BOOT_JDK_VERSION); ignoring]) >> AC_MSG_NOTICE([(Your Boot JDK must be version 8 or 9)]) >> BOOT_JDK_FOUND=no >> >> Samuel Marks >> http://linkedin.com/in/samuelmarks >> >> BTW: I posted in kulla-dev but they told me to post here - >> http://mail.openjdk.java.net/pipermail/kulla-dev/2016-July/001508.html >> >