RFR 8159635: JShell API: Set compiler options

[Jan Lahoda]

Hi,

A few comments:
-should these extra options also be used by AnalyzeTasks created by 
SourceCodeAnalysisImpl? I am not sure if the options we expect people to 
set could have impact e.g. on the tab completion.
-JShell.Builder.compilerOptions says:
Sets additional compiler options for generating bytecode.

But it adds the new options to the list - it might be better to say 
"Adds additional ..." or "Appends additional compiler options..." so 
that it is clearer it won't clear options that were set before. (I am 
also thinking if the method should be "addCompilerOptions", but given 
the other methods are not prefixed with "set", "add" is probably not 
necessary.)

Jan

On 18.6.2016 08:40, Robert Field wrote:
> Please review --
>
> Bug:
>      https://bugs.openjdk.java.net/browse/JDK-8159635
>
> Webrev:
>      http://cr.openjdk.java.net/~rfield/8159635v0.webrev/
>
> Spec:
>      http://cr.openjdk.java.net/~rfield/jshell_8159635/
>
>      Specifically:
> http://cr.openjdk.java.net/~rfield/jshell_8159635/jdk/jshell/JShell.Builder.html#compilerOptions-java.lang.String...-
>
>
> Thanks,
> Robert
>