RFR 8160009 / 8160035 : multi-package javadoc for JShell

[Robert Field]

On 06/23/16 13:51, Jan Lahoda wrote:
> To me, seems mostly fine. 

Good

> I wonder if RemoteCodes should be numerical constants - enum might be 
> better (it could still have the numerical code inside).

These are ONLY used across the communication channel, and thus would 
never be usable directly as enums.  They could be encoded and decoded in 
each direction, but that seems to me that it would add complexity rather 
than clarity.

Thank,
Robert


>
> Jan
>
> On 22.6.2016 20:42, Robert Field wrote:
>> Please review these two interrelated bugs --
>>
>> Bugs:
>>
>>      8160009: JShell: Add SPI and execution to generated JShell javadoc
>> (root ws)
>>      https://bugs.openjdk.java.net/browse/JDK-8160009
>>
>>      8160035: JShell API: Add javadoc overview and package files
>>      https://bugs.openjdk.java.net/browse/JDK-8160035
>>
>> Parent bug:
>>
>>      8159118: JShell API: Provide abstract and concrete implementations
>> of ExecutionControl SPI
>>      https://bugs.openjdk.java.net/browse/JDK-8159118
>>
>> Webrevs:
>>
>>      Langtools
>>      http://cr.openjdk.java.net/~rfield/8160035v0.webrev/
>>
>>      Root
>>      http://cr.openjdk.java.net/~rfield/8160009v0.webrev/
>>
>> Generate javadoc:
>>
>>     http://cr.openjdk.java.net/~rfield/jshell_8160009/
>>
>> Thanks,
>> Robert
>>