RFR 8152296: langtools/test/jdk/jshell/ToolReloadTest.java failing if there is no persisted history

Robert Field robert.field at oracle.com
Mon Mar 21 15:55:29 UTC 2016


Thumbs up.

-Robert

On 03/21/16 06:28, Jan Lahoda wrote:
> Hi,
>
> Recently, I changed ConsoleIOContext to use UnsupportedTerminal while 
> running test, to avoid setting the terminal to the raw mode. Seems 
> that does not work well - some features, e.g. history, don't work 
> correctly with the UnsupportedTerminal. So, I propose to change that 
> to a dummy testing terminal.
>
> Also, the tests are currently using the global Preferences, so they 
> are dependent on the preexisting state and on each other - I propose 
> to change that to memory based Preferences, which would be created 
> from scratch for each test.
>
> Webrev:
> http://cr.openjdk.java.net/~jlahoda/8152296/webrev.00/
>
> Any comments are welcome.
>
> Thanks,
>     Jan



More information about the kulla-dev mailing list