RFR 8167636: jshell tool: Edit Pad should be in its own module

Robert Field robert.field at oracle.com
Tue Nov 1 04:16:33 UTC 2016


New module layout:

    jdk.internal.ed -- built-in editor SPI and external editor support.  
In its own module so it can be used by other tools.

    jdk.editpad -- Edit Pad provider of built-in editor SPI

both now in the jdk repo.

Please review...

Bugs:

     8167636: jshell tool: Edit Pad should be in its own module
     https://bugs.openjdk.java.net/browse/JDK-8167636

             8168972: Editor support: move built-in and external editor 
support to the jdk repo
             https://bugs.openjdk.java.net/browse/JDK-8168972

             8168974: Editor support: include properties file in image
             https://bugs.openjdk.java.net/browse/JDK-8168974

     8167639: jshell tool: Edit Pad has readability issues
     https://bugs.openjdk.java.net/browse/JDK-8167639

Webrevs:

     Langtools (8167636)
     http://cr.openjdk.java.net/~rfield/8167636v3.webrev/

     jdk (8168972  &  8167639)
     http://cr.openjdk.java.net/~rfield/8168972v3.webrev/

     top-level (8168974)
     http://cr.openjdk.java.net/~rfield/8168974v3.webrev/

Thanks,
Robert

-----------------------------------------------

Robert Field wrote:
> Per  comments:
> BuildInEditorProvider now interface.
> CountDownLatch hidden in EditPadProvider.
> Plain old JFrame.
>
>
> New webrev:
> http://cr.openjdk.java.net/~rfield/8167636v2.webrev/
>
> Thanks again,
> Robert

On 10/23/16 06:42, Robert Field wrote:
> New version --
>
> Both runtime-time and compile-time dependency on ActionListener (and 
> thus java.desktop) removed from ConsoleIOContext.
> All key sequences work on jlinked image without desktop.
>
> Webrev:
>     http://cr.openjdk.java.net/~rfield/8167636v1.webrev/
>
> -Robert
>
> On 10/22/16 23:52, Robert Field wrote:
>> Note: jdk.internal.le and thus the jshell tool's ConsoleIOContext 
>> have a dependency on java.awt.event.ActionListener.
>> The former uses reflection to quietly ignore when it isn't present -- 
>> at a loss of functionality (functionality we use).
>> This code has a hack until I can discuss with Jan what the options are.
>> Ideally jdk.internal.le can lose it's dependency; Otherwise, I will 
>> change ConsoleIOContext to use reflection, which will mean a loss of 
>> shift-tab and shortcut+* functionality when java.desktop is not in 
>> the image.
>>
>> -Robert
>>
>>
>> On 10/22/16 21:14, Robert Field wrote:
>>> Remove the dependency of the jshell tool on the java.desktop module.
>>> Uses modules and ServiceLoader so that Edit Pad is optional -- that 
>>> is, a jlink'ed image can be produced without Edit Pad and without 
>>> java.desktop
>>>
>>> Bug:
>>>     https://bugs.openjdk.java.net/browse/JDK-8167636
>>>
>>> Webrev:
>>>     http://cr.openjdk.java.net/~rfield/8167636v0.webrev/
>>>
>>> Thanks,
>>> Robert
>>>
>>
>



More information about the kulla-dev mailing list