RFR 8129559: JShell: compilation fails if class, method or field is annotated and has modifiers

[Robert Field]

On 11/03/16 08:25, Jan Lahoda wrote:
> Ok, I think. I wonder if it wouldn't be easier to use javac's lexer 
> (JavaTokenizer) to detect the comments, and/or 
> JavacParser.modifiersOpt to detect the modifiers.

Tokens.Comment  does not seem to have start/end position in any obvious 
way.  And, that would, of course, be a rewrite.

> BTW, should Unicode escapes be supported?

Yes.  Perhaps that should be handled as a separate issue.

-Robert

>
> Jan
>
> On 2.11.2016 03:47, Robert Field wrote:
>> Please review....
>>
>> Bugs:
>>
>>      8129559: JShell: compilation fails if class, method or field is
>> annotated and has modifiers
>>      https://bugs.openjdk.java.net/browse/JDK-8129559
>>
>>      8080354: JShell: Runtime visible annotations cannot be retrieved
>>      https://bugs.openjdk.java.net/browse/JDK-8080354
>>
>> Webrev:
>>
>>      http://cr.openjdk.java.net/~rfield/8129559v0.webrev/
>>
>> Thanks,
>> Robert
>>