RFR JDK-8169595: jshell tool: pasting multiple lines hangs input

Robert Field robert.field at oracle.com
Fri Nov 11 18:16:51 UTC 2016


Thumbs up!

-Robert

On 11/11/16 09:49, Jan Lahoda wrote:
> Hi,
>
> There's a code in jdk.internal.le to query cursor position. This is 
> done by writing an escape code to the output, and reading an escape 
> code with the cursor position from the input. As the input may also 
> contain user's input, the read text may look like 
> "<user-input>\033[72;9R". There is a regexp pattern to recognize the 
> cursor position code, but it won't match the text if <user-input> 
> contains line endings.
>
> This patch adds DOTALL to the pattern, so it will match the user's 
> input even if it is multi-line.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8169595
> Webrev: http://cr.openjdk.java.net/~jlahoda/8169595/webrev.00/
>
> Any comments are welcome!
>
> Thanks,
>     Jan



More information about the kulla-dev mailing list