RFR 8169519: JShell: Handle start-up failures and hangs gracefully

[Robert Field]

On 11/14/16 14:01, Jan Lahoda wrote:
> Overall, seems OK to me. Two comments:
> -DyingRemoteAgent should have a license header:

Ooops, fixed.

> http://cr.openjdk.java.net/~rfield/8169519v1.webrev/test/jdk/jshell/DyingRemoteAgent.java.html 
>
> -the tests seem to depend on exact exception messages - is there a 
> risk of that being unstable? (And, possibly, platform-specific?)

The tests assume that the failure has occurred and is caught in a 
specific way, which is testing what is fixed.
It is certainly possible that timing or platform issues could cause 
other behaviors -- but, to some extent, that would be a failure of the code.
There is nothing platform specific in the layers of message that is 
checked, those are all JShell layers.

-Robert

>
> Jan
>
> On 14.11.2016 20:14, Robert Field wrote:
>> Updated webrev:
>>
>>      http://cr.openjdk.java.net/~rfield/8169519v1.webrev/
>>
>> Change of how localhost determined (thanks, Jan).  Tests not included in
>> webrev,
>>
>> -Robert
>>
>> On 11/09/16 20:01, Robert Field wrote:
>>> JShell: Handle start-up failures and hangs gracefully -- 
>>> specifically --
>>> Add time-outs so hangs do not lock out users and so fail-over can
>>> function.
>>> Handle failures more gracefully, including cleaning up remote process.
>>> Fail-fast for better user-experience and better failure handling.
>>> Surface failure in API.
>>> Add testing hooks.
>>> Better failure information.
>>>
>>> Bugs:
>>>
>>>     8169519: JShell: Handle start-up failures and hangs gracefully
>>>     https://bugs.openjdk.java.net/browse/JDK-8169519
>>>
>>>     8166581: JShell: locks forever if -R options is wrong
>>>     https://bugs.openjdk.java.net/browse/JDK-8166581
>>>
>>> Webrev:
>>>
>>>     http://cr.openjdk.java.net/~rfield/8169519v0.webrev/
>>>
>>> Specdiff:
>>>
>>> http://cr.openjdk.java.net/~rfield/8169519v0.specdiff/overview-summary.html 
>>>
>>>
>>>
>>> JShell API:
>>>
>>>     http://cr.openjdk.java.net/~rfield/8169519v0.jshellAPI/
>>>
>>>
>>> Thanks,
>>> Robert
>>>
>>