RFR (s) 8114842: JShell: SourceCodeAnalysis splits code with array initialiazer incorrectly

Jan Lahoda jan.lahoda at oracle.com
Fri Nov 18 16:09:34 UTC 2016


Seems to me the handling of commas in declarations is not quite correct. 
Consider for example:
---
jshell> int m = 0,
|  Error:
|  reached end of file while parsing
|  int m = 0,
|            ^

jshell> int n1 = 0, n2
|  Error:
|  reached end of file while parsing
|  int n1 = 0, n2
|                ^

jshell> int n1 = 0, n2 =
|  Error:
|  reached end of file while parsing
|  int n1 = 0, n2 =
|                  ^
---

Would something along these lines work better?
http://cr.openjdk.java.net/~jlahoda/8114842/comma-in-decls.diff

Jan


On 16.11.2016 23:35, Robert Field wrote:
> Bug:
>
>      https://bugs.openjdk.java.net/browse/JDK-8114842
>
> Webrev:
>
>      http://cr.openjdk.java.net/~rfield/8114842v0.webrev/
>
> Thanks,
> Robert
>


More information about the kulla-dev mailing list