RFR 8170015: JShell: /help output looks terrible on a 100 column wide terminal

Jan Lahoda jan.lahoda at oracle.com
Mon Nov 28 16:47:45 UTC 2016


Overall seems ok.

Nit:
-the return in JShellTool.prefix appears to be indented one space too much.

Jan


On 26.11.2016 23:14, Robert Field wrote:
> Please review...
>
> Bugs:
>
>      8170015: jshell tool: /help output looks terrible on a 100 column
> wide terminal
>      https://bugs.openjdk.java.net/browse/JDK-8170015
>
>      8170368: jshell tool: post setting not properly applied, line-ends
> not prefixed correctly
>      https://bugs.openjdk.java.net/browse/JDK-8170368
>
> Webrev:
>
>      http://cr.openjdk.java.net/~rfield/8170015v1.webrev/
>
> Thanks,
> Robert
>


More information about the kulla-dev mailing list