RFR 8131019: jshell tool: access javadoc from tool

Robert Field robert.field at oracle.com
Tue Oct 18 20:34:23 UTC 2016


One concern:

     142 jshell.console.see.javadoc = <invoke documentation again to see 
more documentation>

I think this may be confusing.  For seeing more with regular tab the 
existing prompt is this (and seems clear):

     141 jshell.console.see.more = <press tab to see more>

Also, you are adding:

     143 jshell.console.no.javadoc = <no javadoc found>

Can we make the doc one:

     142 jshell.console.see.javadoc = <press shift-tab again to see javadoc>

otherwise looks good.

Thanks,
Robert

On 10/17/16 09:08, Jan Lahoda wrote:
> Hello,
>
> This patch adds ability to show javadoc inside JShell (by showingg it 
> on the second invocation of the Shift-<tab> documentation). In 
> addition to jdk.jshell changes, there is a support in jdk.compiler, 
> that is expected to be reused by jjs.
>
> Bug:
> https://bugs.openjdk.java.net/browse/JDK-8131019
>
> Webrev:
> http://cr.openjdk.java.net/~jlahoda/8131019/webrev.00/
>
> Any feedback is welcome!
>
> Thanks,
>     Jan



More information about the kulla-dev mailing list