RFR 8131019: jshell tool: access javadoc from tool

[Jan Lahoda]

Hi Robert,

Thanks for looking at this and for the comment.

On 18.10.2016 22:34, Robert Field wrote:
> One concern:
>
>      142 jshell.console.see.javadoc = <invoke documentation again to see
> more documentation>
>
> I think this may be confusing.  For seeing more with regular tab the
> existing prompt is this (and seems clear):
>
>      141 jshell.console.see.more = <press tab to see more>
>
> Also, you are adding:
>
>      143 jshell.console.no.javadoc = <no javadoc found>
>
> Can we make the doc one:
>
>      142 jshell.console.see.javadoc = <press shift-tab again to see
> javadoc>

I used a more general "documentation", as the same text may be used for 
expanding command documentation (like: "/list <shift-tab>"). Maybe we 
want two different texts? I.e.

jshell.console.see.javadoc = <press shift-tab again to see javadoc>

for javadoc, and:

jshell.console.see.help = <press shift-tab again to see detailed help>

for the command documentation?

Thanks,
    Jan

>
> otherwise looks good.
>
> Thanks,
> Robert
>
> On 10/17/16 09:08, Jan Lahoda wrote:
>> Hello,
>>
>> This patch adds ability to show javadoc inside JShell (by showingg it
>> on the second invocation of the Shift-<tab> documentation). In
>> addition to jdk.jshell changes, there is a support in jdk.compiler,
>> that is expected to be reused by jjs.
>>
>> Bug:
>> https://bugs.openjdk.java.net/browse/JDK-8131019
>>
>> Webrev:
>> http://cr.openjdk.java.net/~jlahoda/8131019/webrev.00/
>>
>> Any feedback is welcome!
>>
>> Thanks,
>>     Jan
>