RFR 8163840 (v3): jshell tool: provide way to display configuration settings
Jan Lahoda
jan.lahoda at oracle.com
Wed Oct 19 19:14:30 UTC 2016
In Feedback.java, there is:
816 .map(v -> v.name().toLowerCase())
This is going to cause problems on the Turkish locale, where "I" will
get converted to "ı" instead of "i". Suggest to use toLowerCase(Locale.US).
Otherwise, seems OK to me.
Jan
On 19.10.2016 06:34, Robert Field wrote:
> Please review this change which allows all settings to be shown.
> Revamped as discussed in the thread "JShell: showing and retaining
> settings" (copied into bug Description).
>
> Bug:
> https://bugs.openjdk.java.net/browse/JDK-8163840
>
> Webrev:
> http://cr.openjdk.java.net/~rfield/8163840v3.webrev/
>
> Thanks,
> Robert
More information about the kulla-dev
mailing list