RFR 8167636: jshell tool: Edit Pad should be in its own module

Robert Field robert.field at oracle.com
Sun Oct 23 13:42:41 UTC 2016


New version --

Both runtime-time and compile-time dependency on ActionListener (and 
thus java.desktop) removed from ConsoleIOContext.
All key sequences work on jlinked image without desktop.

Webrev:
     http://cr.openjdk.java.net/~rfield/8167636v1.webrev/

-Robert

On 10/22/16 23:52, Robert Field wrote:
> Note: jdk.internal.le and thus the jshell tool's ConsoleIOContext have 
> a dependency on java.awt.event.ActionListener.
> The former uses reflection to quietly ignore when it isn't present -- 
> at a loss of functionality (functionality we use).
> This code has a hack until I can discuss with Jan what the options are.
> Ideally jdk.internal.le can lose it's dependency; Otherwise, I will 
> change ConsoleIOContext to use reflection, which will mean a loss of 
> shift-tab and shortcut+* functionality when java.desktop is not in the 
> image.
>
> -Robert
>
>
> On 10/22/16 21:14, Robert Field wrote:
>> Remove the dependency of the jshell tool on the java.desktop module.
>> Uses modules and ServiceLoader so that Edit Pad is optional -- that 
>> is, a jlink'ed image can be produced without Edit Pad and without 
>> java.desktop
>>
>> Bug:
>>     https://bugs.openjdk.java.net/browse/JDK-8167636
>>
>> Webrev:
>>     http://cr.openjdk.java.net/~rfield/8167636v0.webrev/
>>
>> Thanks,
>> Robert
>>
>



More information about the kulla-dev mailing list