RFR 8167637: jshell tool: /edit should use EDITOR setting

Jan Lahoda jan.lahoda at oracle.com
Sun Oct 23 17:58:13 UTC 2016


Overall, seems OK to me. It seems there is a missing
setEditorEnvSubtest();
call at the end of (after the last block of setEnvVar in):
ToolCommandOptionTest.java#setEditorEnvTest

Jan

On 21.10.2016 09:14, Robert Field wrote:
> Please review --
>
> Bugs:
>
>      8167637: jshell tool: /edit should use EDITOR setting
>      https://bugs.openjdk.java.net/browse/JDK-8167637
>
>      8167640: jshell tool: external editor temp file should be *.java
>      https://bugs.openjdk.java.net/browse/JDK-8167640
>
> Webrev:
>
>      http://cr.openjdk.java.net/~rfield/8167637v0.webrev/
>
> Thanks,
> Robert
>


More information about the kulla-dev mailing list