RFR 8167637: jshell tool: /edit should use EDITOR setting

Robert Field robert.field at oracle.com
Tue Oct 25 00:07:04 UTC 2016


On 10/23/16 10:58, Jan Lahoda wrote:
> Overall, seems OK to me. It seems there is a missing
> setEditorEnvSubtest();
> call at the end of (after the last block of setEnvVar in):
> ToolCommandOptionTest.java#setEditorEnvTest

Sure enough.  The last set-up wasn't getting tested.  Fixed.

Pushed.

Thanks,
Robert

>
> Jan
>
> On 21.10.2016 09:14, Robert Field wrote:
>> Please review --
>>
>> Bugs:
>>
>>      8167637: jshell tool: /edit should use EDITOR setting
>>      https://bugs.openjdk.java.net/browse/JDK-8167637
>>
>>      8167640: jshell tool: external editor temp file should be *.java
>>      https://bugs.openjdk.java.net/browse/JDK-8167640
>>
>> Webrev:
>>
>>      http://cr.openjdk.java.net/~rfield/8167637v0.webrev/
>>
>> Thanks,
>> Robert
>>



More information about the kulla-dev mailing list