WIP: 8154714: JShell API: addExports support [for Java 9.X]

[ShinyaYoshida]

2016-09-02 2:25 GMT+09:00 Robert Field <robert.field at oracle.com>:

>
> On 09/01/16 05:36, ShinyaYoshida wrote:
>
>> Hi all,
>> I've implemented this feature to JShell API and Tool with full completion:
>> Bugs: https://bugs.openjdk.java.net/browse/JDK-8154714
>>
>> jdk: http://cr.openjdk.java.net/~shinyafox/kulla/8154714/webrev.00.jdk/ <
>> http://cr.openjdk.java.net/%7Eshinyafox/kulla/8154714/webrev.00.jdk/>
>> langtools: http://cr.openjdk.java.net/~shinyafox/kulla/8154714/webrev.
>> 00.langtools/ <http://cr.openjdk.java.net/%7
>> Eshinyafox/kulla/8154714/webrev.00.langtools/>
>>
>>
> I'll look at this today.
>
> This is missing the train of Java 9.0 but it could catch the train of Java
>> 9.1 or later.
>> I want to get your comments for this.
>>
>
> I've assigned this to you.  I think it is important to get this in for 9.
> So, if you think it can be ready soon we can make it happen.

Hi Robert,
Thank you！！ Probably I can prepare the first RFR in 2 or 3 days.
I wonder if  you could work on the documentation of the API and the tool
instead?


>
>> jshell> /set add-exports jdk.jconsole sun.tools.jconsole
>>
>
> We don't currently have any hyphenated sub-commands.  What do people think
> of just having it be "exports"?

Absolutely!! It seems to me that it's reasonable.

Questions:
- Subcommand of /set is reasonable? Similar command, /classpath, to make
users available to use new packages is not a subcommand of /set.
- Should we need retain feature to this?

Regards,
shinyafox(Shinya Yoshida)



>
>
>
>> jshell> import sun.tools.jconsole.*
>>
>> jshell> LocalVirtualMachine.getAllVirtualMachines().forEach((k, v) ->
>> System.out.println(k + ":" + v))
>> 10778:jdk.jshell/jdk.internal.jshell.tool.JShellTool
>> 10826:jdk.jshell.execution.RemoteExecutionControl 35548
>> 28447:org.netbeans.Main --cachedir /home/bitter_fox/.cache/netbeans/8.0.1
>> --userdir /home/bitter_fox/.netbeans/8.0.1 --branding nb
>>
>> Currently, there is no testing, so it will be required to add test.
>>
>
> Of course.
>
>
>> Regards,
>> shinyafox(Shinya Yoshida)
>>
>
> Thanks,
> Robert
>
>