RFR 9: JDK-8178481: jdk/jshell/CompletionSuggestionTest.java routinely fails

[Robert Field]

Thumbs up!

Robert



On April 19, 2017 6:31:59 AM Jan Lahoda <jan.lahoda at oracle.com> wrote:

> Hi,
>
> The CompletionSuggestionTest sometimes fails with an error like:
>
> java.lang.AssertionError: Input: import c|, [com,
> completion_suggestion_test]: lists don't have the same size expected [1]
> but found [2]
>
> The cause I think is this: the classpath used by JShell contains "."
> (current directory). And the test is testing completion for "import
> c<tab>". So if some of the other tests creates a directory inside the
> current directory, it is included in the completion, and as the test
> expects the result is just "com", the test fails.
>
> The proposed change is to loosen the check to only verify that the
> output contains "com", and ignore the other items. That should be OK, as
> I believe the main intent in this test is to verify completion works
> right after "import".
>
> Bug:
> https://bugs.openjdk.java.net/browse/JDK-8178481
>
> Webrev:
> http://cr.openjdk.java.net/~jlahoda/8178481/webrev.00/
>
> Thanks,
>      Jan