RFR 8182270: JShell API: snippet information / 8166334: jshell tool: shortcut: expression/statement to method

[Robert Field]

Thanks for the review.
Typo fixed.
CSR approved while I out.
Pushed to 10.

-Robert

On 06/23/17 09:13, Jan Lahoda wrote:
> Typo:
> ToolShiftTabTest.java:
> @summary test shift-tab shortcuts "fixs"
> =>
> @summary test shift-tab shortcuts "fixes"
>
> Otherwise looks good.
>
> Jan
>
> On 21.6.2017 04:29, Robert Field wrote:
>> Please review: Adds new shift-tab-m shortcut for converting expressions
>> or statements into methods.  And adds to the JShell API, non-evaluative
>> Snippet information access, required the new tool functionality, and
>> generally useful for analyzing source snippets before evaluation.
>>
>> Update...
>>
>> With input from Jan, added direct UI level tests of, not only the new
>> shift-tab-m functionality, but, of all shift-tab functionality.
>>
>> Fixed an obscure issue of temp variable numbering after ctrl-C'ing a
>> shift-tab-m.
>>
>>
>> On 06/15/17 23:14, Robert Field wrote:
>>> Please review --
>>>
>>> Bugs:
>>>
>>>     JShell API: Tools need snippet information without evaluating 
>>> snippet
>>>     https://bugs.openjdk.java.net/browse/JDK-8182270
>>>
>>>     jshell tool: shortcut: expression/statement to method
>>>     https://bugs.openjdk.java.net/browse/JDK-8166334
>>>
>>> Webrev:
>>>
>>>     http://cr.openjdk.java.net/~rfield/8182270v0.webrev/
>>>
>>> Thanks,
>>> Robert
>>>
>>