tags are removed, that were being reported by tidy. Also in Snippet.Kind, it seems strange, but not wrong, to put a sentence after the usages of the @jls tag. That sentence becomes part of the body of the @jls tag, and not part of the main description, which may not be as intended. However, at this point, I have not changed that part of the text. JBS: https://bugs.openjdk.java.net/browse/JDK-8184225 Webrev: http://cr.openjdk.java.net/~jjg/8184225/webrev.00 The changes are simple enough that I have not published an updated API. -- Jon From jan.lahoda at oracle.com Wed Jul 12 13:21:20 2017 From: jan.lahoda at oracle.com (Jan Lahoda) Date: Wed, 12 Jul 2017 15:21:20 +0200 Subject: RFR: 8184225: Fix accessibility and tidy issues in jdk.jshell docs In-Reply-To: <596588EB.3070207@oracle.com> References: <596588EB.3070207@oracle.com> Message-ID: <59662250.5010701@oracle.com> Seems OK. Jan On 12.7.2017 04:26, Jonathan Gibbons wrote: > Please review some simple changes to the HTML markup for the jdk.jshell > API docs. > There are no material changes to the specification. > > In JdiExecutionControlProvider, an HTML table is updated for accessibility. > In Snippet.Kind, some redundant
tags are removed, that were being > reported by tidy. > > Also in Snippet.Kind, it seems strange, but not wrong, to put a sentence > after the usages > of the @jls tag. That sentence becomes part of the body of the @jls tag, > and not part > of the main description, which may not be as intended. > However, at this point, I have not changed that part of the text. > > JBS: https://bugs.openjdk.java.net/browse/JDK-8184225 > Webrev: http://cr.openjdk.java.net/~jjg/8184225/webrev.00 > > The changes are simple enough that I have not published an updated API. > > -- Jon From jonathan.gibbons at oracle.com Wed Jul 12 15:04:26 2017 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Wed, 12 Jul 2017 08:04:26 -0700 Subject: RFR: 8184225: Fix accessibility and tidy issues in jdk.jshell docs In-Reply-To: <59662250.5010701@oracle.com> References: <596588EB.3070207@oracle.com> <59662250.5010701@oracle.com> Message-ID: <072f56ed-8a3a-ff82-f42f-ac70528aa217@oracle.com> Thanks. -- Jon On 7/12/17 6:21 AM, Jan Lahoda wrote: > Seems OK. > > Jan > > On 12.7.2017 04:26, Jonathan Gibbons wrote: >> Please review some simple changes to the HTML markup for the jdk.jshell >> API docs. >> There are no material changes to the specification. >> >> In JdiExecutionControlProvider, an HTML table is updated for >> accessibility. >> In Snippet.Kind, some redundant
tags are removed, that were being
>> reported by tidy.
>>
>> Also in Snippet.Kind, it seems strange, but not wrong, to put a sentence
>> after the usages
>> of the @jls tag. That sentence becomes part of the body of the @jls tag,
>> and not part
>> of the main description, which may not be as intended.
>> However, at this point, I have not changed that part of the text.
>>
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8184225
>> Webrev: http://cr.openjdk.java.net/~jjg/8184225/webrev.00
>>
>> The changes are simple enough that I have not published an updated API.
>>
>> -- Jon
From amy.lu at oracle.com Wed Jul 19 01:38:38 2017
From: amy.lu at oracle.com (Amy Lu)
Date: Wed, 19 Jul 2017 09:38:38 +0800
Subject: JDK 10 RFR of JDK-8184894: Mark ExternalEditorTest.java as
intermittently failing, demote to tier 2
Message-ID: <6ed6772a-07f0-4bbd-b54a-0d28f4a7ab03@oracle.com>
jdk/jshell/ExternalEditorTest.java
This test has been seen to intermittently fail (JDK-8176253,
JDK-8178353, JDK-8159229). It should be marked accordingly and demoted
from tier 1 to tier 2 until the reliability issues are resolved.
Please review the patch to add intermittent key and change to tier2.
bug: https://bugs.openjdk.java.net/browse/JDK-8184894
webrev: http://cr.openjdk.java.net/~amlu/8184894/webrev.00/
Thanks,
Amy
--- old/test/TEST.groups 2017-07-19 09:32:05.000000000 +0800
+++ new/test/TEST.groups 2017-07-19 09:32:05.000000000 +0800
@@ -27,11 +27,13 @@
jdk \
lib \
tools \
+ -jdk/jshell/ExternalEditorTest.java \
-jdk/jshell/ToolReloadTest.java \
-jdk/jshell/ToolLocaleMessageTest.java
# (Almost) no langtools tests are tier 2.
tier2 = \
+ jdk/jshell/ExternalEditorTest.java \
jdk/jshell/ToolReloadTest.java \
jdk/jshell/ToolLocaleMessageTest.java
--- old/test/jdk/jshell/ExternalEditorTest.java 2017-07-19 09:32:05.000000000 +0800
+++ new/test/jdk/jshell/ExternalEditorTest.java 2017-07-19 09:32:05.000000000 +0800
@@ -28,6 +28,7 @@
* @modules jdk.jshell/jdk.internal.jshell.tool
* @build ReplToolTesting CustomEditor EditorTestBase
* @run testng ExternalEditorTest
+ * @key intermittent
*/
import java.io.BufferedWriter;
From amy.lu at oracle.com Fri Jul 28 08:10:11 2017
From: amy.lu at oracle.com (Amy Lu)
Date: Fri, 28 Jul 2017 16:10:11 +0800
Subject: JDK 10 RFR of JDK-8184894: Mark ExternalEditorTest.java as
intermittently failing, demote to tier 2
In-Reply-To: <6ed6772a-07f0-4bbd-b54a-0d28f4a7ab03@oracle.com>
References: <6ed6772a-07f0-4bbd-b54a-0d28f4a7ab03@oracle.com>
Message-ID: