RFR (XXS ASAP) 8176241: JShell tests: on full builds CompletionSuggestionTest.testImportStart() fails

joe darcy joe.darcy at oracle.com
Mon Mar 6 23:43:17 UTC 2017


Looks fine; cheers,

-Joe


On 3/6/2017 3:40 PM, Robert Field wrote:
> Testing on full systems (with both open and closed) are failing 
> because "import o<tab>" completes with "oracle" in addition to the 
> expected "org".
> There is already a test for "import c<tab>", so this case is not 
> needed -- imply removing it addresses the issue.
> Please review...
>
> Bug:
>
>     https://bugs.openjdk.java.net/browse/JDK-8176241
>
> Webrev:
>
>     http://cr.openjdk.java.net/~rfield/8176241v0.webrev/
>
> Diff...
>
>
> diff -r 173dd02c493c test/jdk/jshell/CompletionSuggestionTest.java
> --- a/test/jdk/jshell/CompletionSuggestionTest.java     Mon Mar 06 
> 08:36:05 2017 -0800
> +++ b/test/jdk/jshell/CompletionSuggestionTest.java     Mon Mar 06 
> 15:33:52 2017 -0800
> @@ -23,7 +23,7 @@
>
>  /*
>   * @test
> - * @bug 8131025 8141092 8153761 8145263 8131019 8175886 8176184
> + * @bug 8131025 8141092 8153761 8145263 8131019 8175886 8176184 8176241
>   * @summary Test Completion and Documentation
>   * @library /tools/lib
>   * @modules jdk.compiler/com.sun.tools.javac.api
> @@ -297,7 +297,6 @@
>
>      public void testImportStart() {
>          assertCompletion("import c|", "com");
> -        assertCompletion("import o|", "org");
>      }
>
>      public void testBrokenClassFile() throws Exception {
>



More information about the kulla-dev mailing list