dumb terminal support for jshell
Logan O'Sullivan Bruns
logan at gedanken.org
Wed Mar 8 15:45:34 UTC 2017
Hi,
I just signed the OCA and had a couple of questions on how to best get
started. Most immediately there is a bug I was hoping to help fix.
Partly because it impacts folks like myself use Emacs heavily.
I've noticed that jshell in jdk9 doesn't currently work
well within the shell mode of Emacs. A very minor change to
the terminal handling fixes this and I have a patch for the change.
My trivial patch changes ConsoleIOContext to look at the TERM
environment variable and, if set to "dumb", to use the TestTerminal
instead of one of the platform specific terminals that won't work in an
Emacs buffer or comparable dumb terminal. I was tempted to make the
patch a little better by renaming the TestTerminal to DumbTerminal
since it would then be used for both the test case and the case where a
dumb terminal is requested explicitly via the TERM environment
variable.
I understand that it is probably too late to get it into jdk9 but I'm
wondering if there is someone I could work with to get this change into
jdk10 in either form proposed above and the perhaps into jdk9
eventually. I know the group of Emacs lovers in the world is dwindling
but I'm sure more than just myself would appreciate this being fixed.
For other projects I might find a bug or enhancement
possibility. Fix and test it. File a bug mentioning that I also have a
suggested fix. Then create a pull request referencing the bug.
In this case, I've signed the OCA but I don't see a way to create a
bug? There doesn't seem to be a way to create an account on the bug
database? Where would be the best place to start?
Thanks,
logan
More information about the kulla-dev
mailing list