dumb terminal support for jshell

[Ben Evans]

Hi Logan,

Looking at the bug, it's listed at P4. Now, if I'm reading the project
schedule right, that means it shouldn't be fixed in the JDK 9 repos
until after the GA release (end of July).

However, the JDK 10 repos are open. So, I suggest that you bring your
patch over to AdoptOpenJDK - where we can help you work on a patch and
get it into a decent shape so that when the committers are a bit less
hectic, we can hopefully get it into the JDK 10 repo, and then
backport to a 9 Update once the GA release of 9 is out (if
appropriate).

Does that work? It's a bit more complex than usual, but that's because
we're so close to the release of 9.

Thanks,

Ben

On Wed, Mar 8, 2017 at 8:15 PM, Logan O'Sullivan Bruns
<logan at gedanken.org> wrote:
>
>
> Thanks Jan. Would it be possible for me to work with you on a patch?
>   - logan
>
>
> Sent from my T-Mobile 4G LTE Device
>
> -------- Original message --------
> From: Jan Lahoda <jan.lahoda at oracle.com>
> Date: 3/8/17  9:53 AM  (GMT-08:00)
> To: Logan O'Sullivan Bruns <logan at gedanken.org>, kulla-dev at openjdk.java.net
> Subject: Re: dumb terminal support for jshell
>
> Hi Logan,
>
> I've filled:
> https://bugs.openjdk.java.net/browse/JDK-8176391
>
> Jan
>
> On 8.3.2017 16:45, Logan O'Sullivan Bruns wrote:
>> Hi,
>>
>> I just signed the OCA and had a couple of questions on how to best get
>> started. Most immediately there is a bug I was hoping to help fix.
>> Partly because it impacts folks like myself use Emacs heavily.
>>
>> I've noticed that jshell in jdk9 doesn't currently work
>> well within the shell mode of Emacs. A very minor change to
>> the terminal handling fixes this and I have a patch for the change.
>>
>> My trivial patch changes ConsoleIOContext to look at the TERM
>> environment variable and, if set to "dumb", to use the TestTerminal
>> instead of one of the platform specific terminals that won't work in an
>> Emacs buffer or comparable dumb terminal. I was tempted to make the
>> patch a little better by renaming the TestTerminal to DumbTerminal
>> since it would then be used for both the test case and the case where a
>> dumb terminal is requested explicitly via the TERM environment
>> variable.
>>
>> I understand that it is probably too late to get it into jdk9 but I'm
>> wondering if there is someone I could work with to get this change into
>> jdk10 in either form proposed above and the perhaps into jdk9
>> eventually. I know the group of Emacs lovers in the world is dwindling
>> but I'm sure more than just myself would appreciate this being fixed.
>>
>> For other projects I might find a bug or enhancement
>> possibility. Fix and test it. File a bug mentioning that I also have a
>> suggested fix. Then create a pull request referencing the bug.
>>
>> In this case, I've signed the OCA but I don't see a way to create a
>> bug? There doesn't seem to be a way to create an account on the bug
>> database? Where would be the best place to start?
>>
>> Thanks,
>>    logan
>>