RFR 8199193: jshell tool: Add support for preview features

Robert Field robert.field at oracle.com
Mon Apr 23 15:41:04 UTC 2018


On 04/23/18 00:51, Sundararajan Athijegannathan wrote:

> * On the new ToolEnablePreviewTest:
>
> 1) do you need to build KullTesting for this test?
> 2) do you need those @module declarations for this test? Seems like 
> this test stays within public APIs.

All the tool tests clone, probably excess, @modules.  And neither @build 
is, I believe, needed.

I've changed the header to just:

    /*
      * @test
      * @bug 8199193
      * @summary Tests for the --enable-preview option
      * @run testng ToolEnablePreviewTest
      */


New webrev, with only this header changed:

     http://cr.openjdk.java.net/~rfield/8199193v1.webrev/

Thanks,
Robert

>
> -Sundar
>
> On 23/04/18, 12:10 AM, Robert Field wrote:
>> Please review....
>>
>> Bug:
>>
>>     https://bugs.openjdk.java.net/browse/JDK-8199193
>>
>> Webrev:
>>
>>     http://cr.openjdk.java.net/~rfield/8199193v0.webrev/
>>
>> Thanks,
>> Robert
>>
>>



More information about the kulla-dev mailing list