RFR: JDK-8215218: Test ToolTabSnippetTest.testCleaningCompletionTODO failed on Windows
Jan Lahoda
jan.lahoda at oracle.com
Tue Dec 11 14:12:26 UTC 2018
Hi,
After JLine 3.9.0 upgrade (JDK-8214491), the
ToolTabSnippetTest.testCleaningCompletionTODO test failed on Windows (I
ran the tests several times before pushing the change, but sadly did not
see this one, so it may be random).
From the log, it is not quite clear what is the problem. The exception is:
java.lang.InterruptedException
at java.base/java.lang.Object.wait(Native Method)
at java.base/java.lang.Thread.join(Thread.java:1302)
at UITesting.doRunTest(UITesting.java:116)
at
ToolTabSnippetTest.testCleaningCompletionTODO(ToolTabSnippetTest.java:212)
The UITesting.doRunTest is there trying to do Thread.join. It is not
quite clear if the problem is just he InterruptedException from the
join, or is there was already a different failure before, hidden by this
one.
So, I'd like to propose that the InterruptedException is handled by the
test (as we do on other places), and that should either solve the
problem, or we will hopefully start to see the real underlying problem.
Proposed webrev:
http://cr.openjdk.java.net/~jlahoda/8215218/webrev.00/
JBS: https://bugs.openjdk.java.net/browse/JDK-8215218
(Running tests with the patch as well, in case it would reveal something.)
Thanks,
Jan
More information about the kulla-dev
mailing list