From Alan.Bateman at oracle.com Mon Jun 4 15:00:36 2018 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Mon, 4 Jun 2018 16:00:36 +0100 Subject: RFR: JDK-8203891: Upgrade JOpt Simple to 5.0.4 In-Reply-To: <5B0FBC37.2090103@oracle.com> References: <5B0FBC37.2090103@oracle.com> Message-ID: <93d8a88f-7c63-6019-c222-e9687c4a7394@oracle.com> On 31/05/2018 10:11, Jan Lahoda wrote: > Hi, > > I'd like to upgrade the JOpt Simple library we are using to version > 5.0.4. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8203891 > Complete webrev: > http://cr.openjdk.java.net/~jlahoda/8203891/webrev.00/complete/ > > Delta webrev only showing (all) JDK changes in JOpt Simple and related > changes in tests needed for the upgrade, etc.: > http://cr.openjdk.java.net/~jlahoda/8203891/webrev.00/joptsimple.delta/ > > Probably the biggest issue with this upgrade is that for two > subsequent parameters: > "--libs=", "/tmp" > "/tmp" used to be interpreted as the parameter of "libs", but now the > "libs" parameter is empty (as there's nothing behind the '='). See the > changes to test/jdk/tools/jmod/JmodTest.java for an example. > Hopefully, this is a reasonable change. > > How does this look? Surprising to see that jmod needs to be updated too but I think it's okay, the update to the jmods tests too. One question - does the update to make/CompileJavaModules.gmk mean that we were missing the JOpt Simple properties file from the run-time image? -Alan. From jan.lahoda at oracle.com Mon Jun 4 15:23:29 2018 From: jan.lahoda at oracle.com (Jan Lahoda) Date: Mon, 4 Jun 2018 17:23:29 +0200 Subject: RFR: JDK-8203891: Upgrade JOpt Simple to 5.0.4 In-Reply-To: <93d8a88f-7c63-6019-c222-e9687c4a7394@oracle.com> References: <5B0FBC37.2090103@oracle.com> <93d8a88f-7c63-6019-c222-e9687c4a7394@oracle.com> Message-ID: <5B155971.7040504@oracle.com> On 4.6.2018 17:00, Alan Bateman wrote: > On 31/05/2018 10:11, Jan Lahoda wrote: >> Hi, >> >> I'd like to upgrade the JOpt Simple library we are using to version >> 5.0.4. >> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8203891 >> Complete webrev: >> http://cr.openjdk.java.net/~jlahoda/8203891/webrev.00/complete/ >> >> Delta webrev only showing (all) JDK changes in JOpt Simple and related >> changes in tests needed for the upgrade, etc.: >> http://cr.openjdk.java.net/~jlahoda/8203891/webrev.00/joptsimple.delta/ >> >> Probably the biggest issue with this upgrade is that for two >> subsequent parameters: >> "--libs=", "/tmp" >> "/tmp" used to be interpreted as the parameter of "libs", but now the >> "libs" parameter is empty (as there's nothing behind the '='). See the >> changes to test/jdk/tools/jmod/JmodTest.java for an example. >> Hopefully, this is a reasonable change. >> >> How does this look? > Surprising to see that jmod needs to be updated too but I think it's > okay, the update to the jmods tests too. I believe the API has been changed to use List instead of Collection on a few places here: https://github.com/jopt-simple/jopt-simple/commit/b8f859ac95a37dcb9abb084fe226da341963950d So the changes to jmod reflect that. > > One question - does the update to make/CompileJavaModules.gmk mean that > we were missing the JOpt Simple properties file from the run-time image? I believe the properties files have not been part of 4.6, the messages have been hardcoded in the classfiles. So the need to copy them is new. Thanks, Jan > > -Alan. From mandy.chung at oracle.com Mon Jun 4 17:40:10 2018 From: mandy.chung at oracle.com (mandy chung) Date: Mon, 4 Jun 2018 10:40:10 -0700 Subject: RFR: JDK-8203891: Upgrade JOpt Simple to 5.0.4 In-Reply-To: <5B0FBC37.2090103@oracle.com> References: <5B0FBC37.2090103@oracle.com> Message-ID: <799bd973-3d11-b4cc-2f16-f4dc6383b4b2@oracle.com> Hi Jan, On 5/31/18 2:11 AM, Jan Lahoda wrote: > Hi, > > I'd like to upgrade the JOpt Simple library we are using to version 5.0.4. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8203891 > Complete webrev: > http://cr.openjdk.java.net/~jlahoda/8203891/webrev.00/complete/ > > Delta webrev only showing (all) JDK changes in JOpt Simple and related > changes in tests needed for the upgrade, etc.: > http://cr.openjdk.java.net/~jlahoda/8203891/webrev.00/joptsimple.delta/ > > Probably the biggest issue with this upgrade is that for two subsequent > parameters: > "--libs=", "/tmp" > "/tmp" used to be interpreted as the parameter of "libs", but now the > "libs" parameter is empty (as there's nothing behind the '='). This is a reasonable fix and no whitespace is expected following `=`. > See the changes to test/jdk/tools/jmod/JmodTest.java for an example. Hopefully, > this is a reasonable change. 114 "--libs=" + libDir.toString(), Alternatively, you can take out `=` and run it as jmod --libs /tmp "--libs", libDir.toString(), Mandy From jan.lahoda at oracle.com Tue Jun 5 07:29:01 2018 From: jan.lahoda at oracle.com (Jan Lahoda) Date: Tue, 5 Jun 2018 09:29:01 +0200 Subject: RFR: JDK-8203891: Upgrade JOpt Simple to 5.0.4 In-Reply-To: <799bd973-3d11-b4cc-2f16-f4dc6383b4b2@oracle.com> References: <5B0FBC37.2090103@oracle.com> <799bd973-3d11-b4cc-2f16-f4dc6383b4b2@oracle.com> Message-ID: <5B163BBD.9060001@oracle.com> On 4.6.2018 19:40, mandy chung wrote: > Hi Jan, > > On 5/31/18 2:11 AM, Jan Lahoda wrote: >> Hi, >> >> I'd like to upgrade the JOpt Simple library we are using to version >> 5.0.4. >> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8203891 >> Complete webrev: >> http://cr.openjdk.java.net/~jlahoda/8203891/webrev.00/complete/ >> >> Delta webrev only showing (all) JDK changes in JOpt Simple and related >> changes in tests needed for the upgrade, etc.: >> http://cr.openjdk.java.net/~jlahoda/8203891/webrev.00/joptsimple.delta/ > >> Probably the biggest issue with this upgrade is that for two >> subsequent parameters: >> "--libs=", "/tmp" >> "/tmp" used to be interpreted as the parameter of "libs", but now the >> "libs" parameter is empty (as there's nothing behind the '='). > > This is a reasonable fix and no whitespace is expected following `=`. > >> See the changes to test/jdk/tools/jmod/JmodTest.java for an example. >> Hopefully, this is a reasonable change. > > 114 "--libs=" + libDir.toString(), > > Alternatively, you can take out `=` and run it as jmod --libs /tmp > "--libs", libDir.toString(), Yes, that would work as well, but there are already invocations like this in the test. So I opted for using "--libs=" + ... and similar, so that both variants are covered by the test. Thanks, Jan > > Mandy From mandy.chung at oracle.com Tue Jun 5 17:16:51 2018 From: mandy.chung at oracle.com (mandy chung) Date: Tue, 5 Jun 2018 10:16:51 -0700 Subject: RFR: JDK-8203891: Upgrade JOpt Simple to 5.0.4 In-Reply-To: <5B163BBD.9060001@oracle.com> References: <5B0FBC37.2090103@oracle.com> <799bd973-3d11-b4cc-2f16-f4dc6383b4b2@oracle.com> <5B163BBD.9060001@oracle.com> Message-ID: <308ce43a-d585-dc92-9bba-5873780ee555@oracle.com> On 6/5/18 12:29 AM, Jan Lahoda wrote: > > Yes, that would work as well, but there are already invocations like > this in the test. So I opted for using > "--libs=" + ... > and similar, so that both variants are covered by the test. That is fine to keep it as is. The change looks good. Mandy From bitterfoxc at gmail.com Fri Jun 8 23:43:58 2018 From: bitterfoxc at gmail.com (ShinyaYoshida) Date: Sat, 9 Jun 2018 08:43:58 +0900 Subject: RFR 8199907: JShell API: NoSuchFieldError occurred due to accessing variables of intersection type inferred by `var` In-Reply-To: References: Message-ID: Hi Jan and Robert, Sorry for stopping some of my patches. My computer doesn't work well in last two month and now I'm preparing the environment in different PC and it's mostly done. Jan, can you check this RFR? If it's ok, I'll move forward this batch. Regards, shinyafox(Shinya Yoshida) 2018-03-27 3:51 GMT+09:00 Robert Field : > Shinya, The changes look good to me. > > Jan, This is your code being changed, so I would like your review. > > Thanks, > Robert > > > > On 03/24/18 23:55, ShinyaYoshida wrote: > > Hi Robert, > > I've updated bug: > https://bugs.openjdk.java.net/browse/JDK-8199907? > focusedCommentId=14166600&page=com.atlassian.jira. > plugin.system.issuetabpanels:comment-tabpanel#comment-14166600 > > I've realized that there is more simple fix thus I've updated webrev > also: > http://cr.openjdk.java.net/~shinyafox/kulla/8199907/webrev.01/ > > Regards, > shinyafox(Shinya Yoshida) > > 2018-03-25 6:00 GMT+09:00 Robert Field : > >> Hi Shinya, >> >> Thanks for finding and looking into this. >> >> Please add a description of the cause of the problem and the proposed fix >> to the bug. >> >> Please add documentation to the code. >> >> Thanks, >> Robert >> >> >> > On Mar 24, 2018, at 10:32 AM, ShinyaYoshida >> wrote: >> > >> > Hi, >> > >> > Please review the following fix: >> > Webrev: http://cr.openjdk.java.net/~shinyafox/kulla/8199907/webrev/ >> > Bugs: https://bugs.openjdk.java.net/browse/JDK-8199907 >> > >> > Regards, >> > shinyafox(Shinya Yoshida) >> >> > > From chris.hegarty at oracle.com Tue Jun 5 15:05:49 2018 From: chris.hegarty at oracle.com (Chris Hegarty) Date: Tue, 05 Jun 2018 15:05:49 -0000 Subject: RFR: JDK-8203891: Upgrade JOpt Simple to 5.0.4 In-Reply-To: <5B0FBC37.2090103@oracle.com> References: <5B0FBC37.2090103@oracle.com> Message-ID: <18b569fb-e7ab-f0db-e30e-51e7ef299aea@oracle.com> On 31/05/18 10:11, Jan Lahoda wrote: > Hi, > > I'd like to upgrade the JOpt Simple library we are using to version 5.0.4. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8203891 > Complete webrev: > http://cr.openjdk.java.net/~jlahoda/8203891/webrev.00/complete/ > > Delta webrev only showing (all) JDK changes in JOpt Simple and related > changes in tests needed for the upgrade, etc.: > http://cr.openjdk.java.net/~jlahoda/8203891/webrev.00/joptsimple.delta/ > > Probably the biggest issue with this upgrade is that for two subsequent > parameters: > "--libs=", "/tmp" > "/tmp" used to be interpreted as the parameter of "libs", but now the > "libs" parameter is empty (as there's nothing behind the '='). See the > changes to test/jdk/tools/jmod/JmodTest.java for an example. Hopefully, > this is a reasonable change. > > How does this look? Thanks Jan, I think this looks good. -Chris.