RFR: JDK-8203891: Upgrade JOpt Simple to 5.0.4

[Chris Hegarty]

On 31/05/18 10:11, Jan Lahoda wrote:
> Hi,
> 
> I'd like to upgrade the JOpt Simple library we are using to version 5.0.4.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8203891
> Complete webrev: 
> http://cr.openjdk.java.net/~jlahoda/8203891/webrev.00/complete/
> 
> Delta webrev only showing (all) JDK changes in JOpt Simple and related 
> changes in tests needed for the upgrade, etc.:
> http://cr.openjdk.java.net/~jlahoda/8203891/webrev.00/joptsimple.delta/
> 
> Probably the biggest issue with this upgrade is that for two subsequent 
> parameters:
> "--libs=", "/tmp"
> "/tmp" used to be interpreted as the parameter of "libs", but now the 
> "libs" parameter is empty (as there's nothing behind the '='). See the 
> changes to test/jdk/tools/jmod/JmodTest.java for an example. Hopefully, 
> this is a reasonable change.
> 
> How does this look?

Thanks Jan, I think this looks good.

-Chris.